Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set WPCOM_API_STATUS transient for E2E tests #2588

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

martynmjones
Copy link
Contributor

Changes proposed in this Pull Request:

Closes #2587

Updates E2E test data to set the default value for WPCOM_API_STATUS.

Detailed test instructions:

  1. Checkout fix/2587-e2e-tests
  2. npm run test:e2e

@martynmjones martynmjones marked this pull request as ready for review September 5, 2024 15:44
@github-actions github-actions bot added type: bug The issue is a confirmed bug. changelog: fix Took care of something that wasn't working. labels Sep 5, 2024
@martynmjones martynmjones added changelog: none Skip changelog entry for this PR and removed changelog: fix Took care of something that wasn't working. labels Sep 5, 2024
@martynmjones martynmjones merged commit 5d9eeda into develop Sep 5, 2024
12 checks passed
@martynmjones martynmjones deleted the fix/2587-e2e-tests branch September 5, 2024 15:49
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.3%. Comparing base (bf5c219) to head (1c6a902).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             develop   #2588   +/-   ##
=========================================
  Coverage       65.3%   65.3%           
  Complexity      4596    4596           
=========================================
  Files            474     474           
  Lines          17893   17893           
=========================================
  Hits           11685   11685           
  Misses          6208    6208           
Flag Coverage Δ
php-unit-tests 65.3% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@martynmjones
Copy link
Contributor Author

Merged without review as it's a small dev facing change

@eason9487 eason9487 removed the type: bug The issue is a confirmed bug. label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: none Skip changelog entry for this PR
Projects
None yet
2 participants