-
Notifications
You must be signed in to change notification settings - Fork 21
Disable jetpack sync during REST requests #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is night and day. Thanks for a quick fix!
I don't see any issues with the code. But I'm having some trouble seeing much improvements when testing :(. I'm not sure if I'm doing anything wrong, but I installed the new version, generated some keys, and did a simple POST to products from Postman. On On It seems like 0.7 might be slightly faster, but I'm definitely not getting any huge improvements. It could just be me, or something else -- especially if you and others are definitely seeing a difference. Let me know if I can provide any more info. |
Wait, that's true, it's not working for me either. The last time I tried it I may have gotten lucky, I got a couple of less-than-1-second requests in a row and I assumed it was working. I've added some logging and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
I added some debug right before the return:
|
Posting this from Slack: from @DanReyLop
I suggest maybe checking |
Fixing this now. I only did 3 requests and they all came in at 2 seconds. I'll run the automated tests after fixing it to look at the request uri instead and make sure it is consistently better then |
when this filter gets run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. And is working consistently for me now. Definitely much much faster.
Fixes #27
To test:
Note: Bumps version to 0.7.0 also
cc @justinshreve or @DanReyLop for review
cc @westi