Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Theme color: Use dynamic variable from user preferences #4558

Merged
merged 4 commits into from
Jun 15, 2020

Conversation

psealock
Copy link
Collaborator

@psealock psealock commented Jun 11, 2020

Partially addresses #4544

Colors for buttons and various other core Gutenberg elements should get wp-admin theme colors.

Detailed test instructions:

  1. Poke around the app, see button colors rendered correctly.
  2. Edit your user profile

Screen Shot 2020-06-12 at 9 31 29 AM

3. Change to a new color scheme.

Screen Shot 2020-06-12 at 9 33 18 AM

4. See the new colors reflected.

Screen Shot 2020-06-12 at 9 48 18 AM

Note

There are still some instances of colors being overriden where they shouldn't be (breadcrumbs?), some colors need to be tweaked (date range picker), and areas where overrides need to be placed (OBW). I'd like to follow up with those fixes, this PR is just the mechanism for getting G2 colors shown.

Instead of darken, lighten I used color function. See https://github.com/postcss/postcss-color-function#notes-for-former-sass-users

Changelog Note:

  • Enhancement: Use Core colors for styling accents.

@becdetat
Copy link
Contributor

becdetat commented Jun 12, 2020

Roll over on busy state removes the animation, it's like the :hover is given more precedence than .is-busy.

Not sure if this is due to the changes or if this is on master but the 'Dismiss this message' text goes over two lines. Possibly something for @octaedro to look at?

The checkboxes on the industry step are still misaligned, not sure if that was meant to be part of this fix:

The checkboxes and the step checks are also purple, which doesn't really 'go' with the blue buttons, is that right?

@becdetat
Copy link
Contributor

Code looks good, everything looks good, I would say that my comment is out of scope...

@psealock
Copy link
Collaborator Author

Thanks @becdetat for the review.

Thanks for noting the issues you spotted in the first comment, I'll be sure to address those in the follow up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants