Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Remove wc api 🎉 #5075

Merged
merged 4 commits into from
Sep 3, 2020
Merged

Remove wc api 🎉 #5075

merged 4 commits into from
Sep 3, 2020

Conversation

psealock
Copy link
Collaborator

@psealock psealock commented Sep 2, 2020

Fixes #3387

Remove wc-api, including imports of withSelect and various constants.

Detailed test instructions:

  1. Boot up the app and make sure webpack is happy.
  2. Poke around and make sure no fatal errors occur.

Changelog Note:

  • Dev: remove wc-api in favor of @woocommerce/data

@samueljseay
Copy link
Contributor

@psealock I haven't tested this yet, but after a global search locally I notice that after this removal there is one more mention of the fresh data framework, to import a constant SECOND, which is just a variable with value 1000 😁

Could we as part of this remove that one import and also delete fresh data from the package.json? Or in a follow up perhaps. I don't know if fresh data gets tree shaken but if it doesn't, removing it would save us on payload.

@psealock
Copy link
Collaborator Author

psealock commented Sep 3, 2020

Could we as part of this remove that one import and also delete fresh data from the package.json?

Thanks for finding that @samueljseay, fixed in 7de71f5

Copy link
Contributor

@becdetat becdetat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@timmyc
Copy link
Contributor

timmyc commented Sep 3, 2020

@psealock psealock merged commit 7232d51 into main Sep 3, 2020
@psealock psealock deleted the remove/wc-api branch September 3, 2020 21:45
@timmyc timmyc added this to the 1.6 milestone Sep 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Layer: Remove fresh-data dependency
4 participants