Add the WpBlock custom element
#39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cases for other source types.Add cases for other source types. 🚀 This comment was generated by the automations bot based on a
|
|
Size Change: 0 B Total Size: 878 kB ℹ️ View Unchanged
|
ockham
reviewed
Jul 29, 2022
| namespace JSX { | ||
| interface IntrinsicElements { | ||
| // eslint-disable-next-line @typescript-eslint/naming-convention | ||
| 'gutenberg-inner-blocks': React.DetailedHTMLProps< |
There was a problem hiding this comment.
We should probably also update the "nomenclature" here, see #21 (comment) 🙂
(tl;dr gutenberg ➡️ wp, or wp-block in other contexts)
There was a problem hiding this comment.
I've taken the liberty of applying some nomenclature fixes in f7b465b. Feel free to revert if you don't like them! 😄
There was a problem hiding this comment.
Thanks @ockham ! I was going to do the same thing but you beat me to it :)
2 tasks
|
There are some action failures but they're not consequential:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding the
<wp-block>custom element to the frontend of woocommerce.The
<wp-block>was originally created in the BHE repo. This PR is bringing it to WBHE.