Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Revisit inline validation message styling #4583

Closed
mikejolley opened this issue Aug 16, 2021 · 0 comments · Fixed by #4734
Closed

Revisit inline validation message styling #4583

mikejolley opened this issue Aug 16, 2021 · 0 comments · Fixed by #4734
Labels
block: checkout Issues related to the checkout block. type: bug The issue/PR concerns a confirmed bug.

Comments

@mikejolley
Copy link
Member

This came up when fixing #4582

Right now the validation messages are positioned absolutely.

Screenshot 2021-08-16 at 13 14 25

This prevents a jump in content when validation errors are shown, but comes at the cost of only supporting errors up to 2 lines. Any more than this and it overlaps other content.

Since we cannot be sure there will only ever be 2 lines of error (this can be impacted by font size, display width, mobile, error text) it seems like a fragile approach we should revisit at some point.

@mikejolley mikejolley added type: bug The issue/PR concerns a confirmed bug. block: checkout Issues related to the checkout block. labels Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: checkout Issues related to the checkout block. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant