This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Remove absolute positioning on validation error messages #4734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -25 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
ralucaStan
approved these changes
Sep 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both blocks tested good.
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Sep 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the absolute positioning on error messages and fixes #4715. This reverts a change in #3968 which did this to prevent the button press issue. After making this change I did the testing steps in #3968 and could no longer replicate the issue on Chrome or Edge, so this may have been a browser issue that has since been resolved?
Fixes #4583
Fixes #4715
Testing
See steps in #3968 for button issue (test for regression)
See steps in #4715 for styling issue
@ralucaStan can you test this your side and confirm it no longer occurs?
Changelog