Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Remove absolute positioning on validation error messages #4734

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

mikejolley
Copy link
Member

This PR removes the absolute positioning on error messages and fixes #4715. This reverts a change in #3968 which did this to prevent the button press issue. After making this change I did the testing steps in #3968 and could no longer replicate the issue on Chrome or Edge, so this may have been a browser issue that has since been resolved?

Fixes #4583
Fixes #4715

Testing

See steps in #3968 for button issue (test for regression)
See steps in #4715 for styling issue

@ralucaStan can you test this your side and confirm it no longer occurs?

Changelog

Fix validation message styling so they never overlap other elements.

@github-actions
Copy link
Contributor

Size Change: -25 B (0%)

Total Size: 1.19 MB

Filename Size Change
build/wc-blocks-style-rtl.css 20.6 kB -13 B (0%)
build/wc-blocks-style.css 20.6 kB -12 B (0%)
ℹ️ View Unchanged
Filename Size
build/active-filters-frontend.js 8.38 kB
build/active-filters.js 8.01 kB
build/all-products-frontend.js 23.1 kB
build/all-products.js 37 kB
build/all-reviews.js 9.59 kB
build/atomic-block-components/add-to-cart--atomic-block-components/button--atomic-block-components/image---a7e2bb9b.js 2.65 kB
build/atomic-block-components/add-to-cart--atomic-block-components/button.js 1.81 kB
build/atomic-block-components/add-to-cart--atomic-block-components/image--atomic-block-components/title.js 333 B
build/atomic-block-components/add-to-cart-frontend.js 8.38 kB
build/atomic-block-components/add-to-cart.js 7.73 kB
build/atomic-block-components/button-frontend.js 1.74 kB
build/atomic-block-components/button.js 875 B
build/atomic-block-components/category-list-frontend.js 469 B
build/atomic-block-components/category-list.js 476 B
build/atomic-block-components/image-frontend.js 1.88 kB
build/atomic-block-components/image.js 1.35 kB
build/atomic-block-components/price-frontend.js 2.09 kB
build/atomic-block-components/price.js 2.11 kB
build/atomic-block-components/rating-frontend.js 563 B
build/atomic-block-components/rating.js 567 B
build/atomic-block-components/sale-badge-frontend.js 860 B
build/atomic-block-components/sale-badge.js 868 B
build/atomic-block-components/sku-frontend.js 388 B
build/atomic-block-components/sku.js 394 B
build/atomic-block-components/stock-indicator-frontend.js 611 B
build/atomic-block-components/stock-indicator.js 612 B
build/atomic-block-components/summary-frontend.js 905 B
build/atomic-block-components/summary.js 911 B
build/atomic-block-components/tag-list-frontend.js 466 B
build/atomic-block-components/tag-list.js 473 B
build/atomic-block-components/title-frontend.js 1.44 kB
build/atomic-block-components/title.js 1.29 kB
build/attribute-filter-frontend.js 18.7 kB
build/attribute-filter.js 12.2 kB
build/blocks-checkout.js 21 kB
build/cart-frontend.js 91.1 kB
build/cart.js 46 kB
build/checkout-frontend.js 95.2 kB
build/checkout-i2-frontend.js 52.5 kB
build/checkout-i2.js 49.4 kB
build/checkout.js 49 kB
build/featured-category.js 7.81 kB
build/featured-product.js 9.51 kB
build/handpicked-products.js 6.35 kB
build/mini-cart-component-frontend.js 36.2 kB
build/mini-cart-frontend.js 2.35 kB
build/mini-cart.js 2.35 kB
build/price-filter-frontend.js 14.5 kB
build/price-filter.js 9.7 kB
build/price-format.js 1.37 kB
build/product-best-sellers.js 6.7 kB
build/product-categories.js 3.38 kB
build/product-category.js 7.56 kB
build/product-new.js 6.85 kB
build/product-on-sale.js 7.2 kB
build/product-search.js 2.66 kB
build/product-tag.js 6.67 kB
build/product-top-rated.js 6.82 kB
build/products-by-attribute.js 7.79 kB
build/reviews-by-category.js 11.6 kB
build/reviews-by-product.js 13.1 kB
build/reviews-frontend.js 9.02 kB
build/single-product-frontend.js 26.2 kB
build/single-product.js 9.79 kB
build/stock-filter-frontend.js 8.75 kB
build/stock-filter.js 7.73 kB
build/vendors--atomic-block-components/add-to-cart-frontend.js 20.3 kB
build/vendors--atomic-block-components/price-frontend.js 5.72 kB
build/wc-blocks-data.js 11.1 kB
build/wc-blocks-editor-style-rtl.css 15.5 kB
build/wc-blocks-editor-style.css 15.5 kB
build/wc-blocks-google-analytics.js 1.98 kB
build/wc-blocks-middleware.js 1.47 kB
build/wc-blocks-registry.js 3.68 kB
build/wc-blocks-shared-context.js 1.54 kB
build/wc-blocks-shared-hocs.js 1.75 kB
build/wc-blocks-vendors-style-rtl.css 1.37 kB
build/wc-blocks-vendors-style.css 1.37 kB
build/wc-blocks-vendors.js 254 kB
build/wc-blocks.js 3.5 kB
build/wc-payment-method-bacs.js 806 B
build/wc-payment-method-cheque.js 806 B
build/wc-payment-method-cod.js 898 B
build/wc-payment-method-paypal.js 839 B
build/wc-payment-method-stripe.js 12.2 kB
build/wc-settings.js 2.92 kB

compressed-size-action

Copy link
Contributor

@ralucaStan ralucaStan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both blocks tested good.

@mikejolley mikejolley added this to the 6.0.0 milestone Sep 15, 2021
@mikejolley mikejolley merged commit 8867b04 into trunk Sep 15, 2021
@mikejolley mikejolley deleted the fix/validation-overlap branch September 15, 2021 13:03
@senadir senadir added the type: bug The issue/PR concerns a confirmed bug. label Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkout i2: coupon code error overlaps bottom border Revisit inline validation message styling
3 participants