Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Enhance navigation with smooth scroll to specific elements #10349

Closed
wants to merge 13 commits into from
Closed

Enhance navigation with smooth scroll to specific elements #10349

wants to merge 13 commits into from

Commits on Jul 13, 2023

  1. Update router to hydrate only interactive regions

    @DAreRodz
    DAreRodz committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    5847587 View commit details
    Browse the repository at this point in the history

  2. Rename link directive to navigation-link

    @DAreRodz
    DAreRodz committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    e2b5431 View commit details
    Browse the repository at this point in the history

  3. Add navigation directives to Query and Pagination blocks

    @DAreRodz
    DAreRodz committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    c0e090c View commit details
    Browse the repository at this point in the history

  4. Enable the Interactivity API by default

    @DAreRodz
    DAreRodz committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    7ab84aa View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Remove client-side navigation meta tag

    @DAreRodz
    DAreRodz committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    91f2432 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Merge branch 'trunk' into add/data-wc-navigation-directives

    @DAreRodz
    DAreRodz committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    56671c9 View commit details
    Browse the repository at this point in the history

  2. Cache initial regions

    @DAreRodz
    DAreRodz committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    35c0e5f View commit details
    Browse the repository at this point in the history

  3. Move data-wc-interactive from query to query-pagination

    @DAreRodz
    DAreRodz committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    7b4c991 View commit details
    Browse the repository at this point in the history

  4. Add woo prefix to navigation id

    @DAreRodz
    DAreRodz committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    ade05ad View commit details
    Browse the repository at this point in the history

  5. Add keys and move wc-interactive back to the query block

    @DAreRodz
    DAreRodz committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    967f00d View commit details
    Browse the repository at this point in the history

  6. Reuse root fragments for each interactive region

    @DAreRodz
    DAreRodz committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    8f1c4a3 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Fix navigation-id retrieval

    @DAreRodz
    DAreRodz committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    763ddf8 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Enhance navigation with smooth scroll to specific elements 

    This commit introduces changes to the directive.js and ProductQuery.php files.

In directives.js, the functionality of fetching a page and updating scroll behavior is enhanced. Now, apart from the smooth or default scroll, the function also considers the 'scrollToSelector' property of a link. It calculates the top position of the element (identified by the selector) in the viewport and uses it for scrolling, providing a more precise and user-friendly scrolling experience.

In ProductQuery.php, the navigation link payload is updated to include a 'scrollToSelector' attribute. This attribute uses a data attribute selector that identifies the product block that the navigation link should scroll to.

These enhancements improve user navigation by allowing smooth scrolling to specific product blocks rather than just the top of the page.
    @imanish003
    imanish003 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    2abadbd View commit details
    Browse the repository at this point in the history