This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Store Customization > Remove placeholder text from the image on the Hero Product Chessboard pattern #11250
Merged
tjcafferkey
merged 1 commit into
trunk
from
remove/write-title-placeholder-from-chessboard-pattern
Oct 17, 2023
Merged
Store Customization > Remove placeholder text from the image on the Hero Product Chessboard pattern #11250
tjcafferkey
merged 1 commit into
trunk
from
remove/write-title-placeholder-from-chessboard-pattern
Oct 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjcafferkey
added
type: enhancement
The issue is a request for an enhancement.
▫️ pattern: commerce-adjacent
focus: patterns
WooCommerce patterns
labels
Oct 14, 2023
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: 0 B Total Size: 1.48 MB ℹ️ View Unchanged
|
albarin
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔝
nefeline
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👾 Spaces FTW!
tjcafferkey
deleted the
remove/write-title-placeholder-from-chessboard-pattern
branch
October 17, 2023 07:55
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds an empty paragraph tag to the Cover block.
Fixes #11181
Why
This is necessary to avoid the "Write title..." placeholder text appearing which needs removing to ensure it is like the designs.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
woocommerce-blocks/hero-product-chessboard
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]
label or a[skip-changelog]
label.Conditional:
[skip-changelog]
label is not present).Changelog