This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
[Product Collection] Fix: HTML Entity Decoding in Taxonomy Controls #11982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imanish003
added
type: bug
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
woocommercebot
requested review from
a team and
gigitux
and removed request for
a team
|
Size Change: +9 B (0%) Total Size: 1.53 MB
ℹ️ View Unchanged
|
kmanijak
approved these changes
Nov 29, 2023
kmanijak
reviewed
Nov 29, 2023
| @@ -250,6 +251,10 @@ const TaxonomyItem = ( { taxonomy, termIds, onChange }: TaxonomyItemProps ) => { | |||
| onChange( newTermIds ); | |||
| }; | |||
|
|
|||
| const decodeHTMLEntities = ( value: string ) => { | |||
| return decodeEntities( value ) || ''; | |||
There was a problem hiding this comment.
What's the need for the wrapping function and || '' part? Seems like decodeEntities always returns a string.
There was a problem hiding this comment.
As you can see in this code, it may return non-string value. Therefore, Just to be extra careful, I added || '' part.
There was a problem hiding this comment.
When I implemented same thing for hand-picked products here, it resulted in an error. That’s why I added extra check here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix HTML entity decoding issue in Taxonomy filters. You can see the issue in screenshot below:
Fixes #9242
Why
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog