This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add React Testing Library #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senadir
added
the
needs: tests
nerrad
approved these changes
May 20, 2020
. For those coming across this, we've validated this in another branch, we're just merging the required packages separately.
nerrad
force-pushed
the
add/react-testing-library
branch
from
2f40aea to
2c50714
Compare
|
Size Change: 0 B Total Size: 1.99 MB ℹ️ View Unchanged
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds React testing library alongside js-dom-sixteen, it will help us write better tests.
It also installs jest-mock-fetch to better mock fetch in our tests.
This only affects tests, so if travis pass, this is fine.
Other PRs should follow with more tests.