This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Split Checkout form component into smaller files (II) #3106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
type: refactor
|
Size Change: +597 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
senadir
approved these changes
Sep 7, 2020
Comment on lines
+64
to
+73
| addressFieldsConfig={ addressFieldsConfig } | ||
| billingFields={ billingFields } | ||
| defaultAddressFields={ defaultAddressFields } | ||
| requirePhoneField={ requirePhoneField } | ||
| setPhone={ setPhone } | ||
| setShippingAsBilling={ setShippingAsBilling } | ||
| setShippingFields={ setShippingFields } | ||
| shippingAsBilling={ shippingAsBilling } | ||
| shippingFields={ shippingFields } | ||
| showPhoneField={ showPhoneField } |
There was a problem hiding this comment.
I feel like we're passing too many props to each component, maybe we can move the hook to inside ShippingFieldsStep and BillingFieldsStep, this is unrelated to this PR, just an idea.
There was a problem hiding this comment.
I found some weird behavior when calling useCheckoutAddress() from ShippingFieldsStep and BillingFieldsStep separately, that's why I moved it one level up so the hook is shared by both components. I will proceed merging as-is, we can investigate it further in the future.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #3062 and part of the fixes I will add for #2319.
How to test the changes in this Pull Request:
Do some smoke testing of the Checkout block: