This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix click on Proceed to checkout bug when Coupon error is visible. #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralucaStan
added
status: needs review
focus: blocks
|
Size Change: -31 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
|
Just making a note that I suggested an alternative to empty elements in using e.preventDefault on the place order button click. If thats not viable, another thing we could consider is making the notice only dismiss after re-entry to the coupon field rather than on blur. |
|
While testing your proposal I noticed that the coupon is actually the only with an error that has a layout shift. All the other inputs in cart & checkout don't have it. So for consistency's sake and for a clean solution I will try to implement the same behaviour for the coupon input |
|
Fixed this by making sure the validation error looks & feels like other validations in the checkout & cart forms. I had to add a small space on the bottom (just CSS) because all the input fields need 1.5em space under them. |
|
@mikejolley ready for review |
mikejolley
approved these changes
Mar 30, 2021
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
The bug happened because of the layout shift produced by the error message disappearance.
ralucaStan
force-pushed
the
fix/3968-coupon-field-error
branch
from
3ea77c9 to
26b7013
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug happened because of the layout shift produced by the error message disappearance.
This PR adds an in-place fix for the Coupon code field. It adds an empty space equal to the space taken up by the error message.
If this becomes an issue for other parts of the project we will need to implement a project-wide sollution.
Fixes #3968
Screenshots
The ticket has the original behavior.
Changes seen here.
How to test the changes in this Pull Request:
Steps to reproduce the behavior:
Make sure you use the Cart block
Add any product to the cart and go to the Cart block.
Enter an invalid coupon code.
See coupon validation error appear
Click on the "Proceed to Checkout" button
Notice you are directed to the Checkout
Changelog