This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Mini Cart block: display a compatibility notice when the user first adds the block in the editor #4945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
frontdevde
and removed request for
a team
|
Size Change: +3.18 kB (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
dinhtungdu
added
focus: FSE
|
@Aljullu @tjcafferkey This PR got assigned to me for review shortly before heading out for AFK. I had hoped to still get to it but I didn't get around to properly test/review it anymore. If one of you could review this one, it'd be highly appreciated. Thank you! 🙏 |
I can take care of it. 👍 |
Aljullu
approved these changes
Oct 18, 2021
There was a problem hiding this comment.
This is working well and thank you for updating the tests!
I noticed the Compatibility notice doesn't look good in the Site Editor. I think it doesn't need to block this PR, so I created a separate issue (#4954) and added it to the Mini Cart epic.
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
|
@dinhtungdu is there anything further that needs to be done on this PR or is it good to go? Let me know if you need any assistance with progressing this. Happy to help! |
|
@tjcafferkey Thanks for checking out, I was focusing on other tasks and missed this. I merged the PR to |
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
…dds the block in the editor (woocommerce#4945)
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
…dds the block in the editor (woocommerce#4945)
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4917.
This PR adds a compatibility notice which reuses the one added for cart and checkout block. I also updated the E2E test for the mini cart to account the notice.
Accessibility
prefers-reduced-motionScreenshots
Testing
Automated Tests
Manual Testing
How to test the changes in this Pull Request:
Performance Impact