Generate ZIP file using GitHub Actions #6661
Conversation
nielslange
added
tools
rubikuserbot
requested review from
a team and
tarunvijwani
and removed request for
a team
|
Size Change: 0 B Total Size: 873 kB ℹ️ View Unchanged
|
|
The release ZIP for this PR is accessible via: |
There was a problem hiding this comment.
Thank you for working on this @nielslange. It works like a charm.
Co-authored-by: Tarun Vijwani <tarun.vijwani@automattic.com>
|
The release ZIP for this PR is accessible via: |
There was a problem hiding this comment.
Looks great, thank you @nielslange ! I've just got some tiny comments, but nothing blocking, so I'm pre-approving.
|
Thanks for your reviews, @tarunvijwani and @sunyatasattva! 🙌 |
|
The release ZIP for this PR is accessible via: |
|
The release ZIP for this PR is accessible via: |
|
@nielslange Do you think we should create only one comment for the release ZIP file link? As the comments are the same, I don't think we need to create more than one per PR. We're doing a similar thing to the compare action at #6736. |
Technically, we could create only one comment. But we would then have to search the corresponding comment. When adding a comment after every push, the link to the ZIP file can always be found as the last comment, which increases the usability. Feel free to create an issue and a PR, if you believe that we benefit from having only one comment. I, personally, don't see an improvement in having only one comment and being forced to search it. |
|
@nielslange @dinhtungdu not sure if it would be possible, but what about adding that link at the bottom of the PR description in a new section, like:
Or perhaps using a custom text field in the GitHub project board and adding the link into that field as it would be always available in the top right sidebar on GitHub? |
|
In terms of usability, there is an issue I have with the current behavior of this action and assets compare action: they create additional notifications in the inbox.
If we can do this, it's the best way IMO. |
@jeffpaul I like both ideas, but couldn't find any information on doing that. While it might not be the perfect solution, it's a working solution. Given the amount of other tasks on my plate, I would rather not invest too much time in this issue. But if you find any information on how to edit a PR description or how to add additional sidebar sections using GitHub Actions, I'm all ears.
@dinhtungdu Correct me if I'm wrong, but aren't notifications a different topic? Every GitHub Action run triggers a notification. Even if we would add the ZIP link to the PR description or in a sidebar panel, you might still receive a notification that the GitHub Action ran. That said, if it really bothers you, feel free to create a PR that improves the current behaviour. I just don't see how having a different behaviour would affect the notifications. |
|
@nielslange I should've explained my point more clearly. To give you more context, I turned off the notification for Actions, I also turn off the email notification. The only source of notifications I'm using is the GitHub Notifications Inbox. When the action creates a comment on a PR, it also triggers a new notification in the inbox which is false-positive to me. FWIW, I strongly agree that the benefit of "the link to the ZIP file can always be found as the last comment" outperforms other cons. So I don't think my original comment is worth implementing anymore. |
|
Thanks for explaining the case you're facing, @dinhtungdu. A quick fix, I can think of, would be to change woocommerce-blocks/.github/workflows/generate-zip.yml Lines 50 to 60 in 995dc56 This definition causes the comment to be added when creating the PR and on every push. Setting the definition to |
I agree with @dinhtungdu, the benefit of having a single comment reused is much greater than the effort required to find it, given most PRs won't get past 5 comments at best. The downside of a new comment on each commit is just too much noise to the point that you won't checking notification anymore. |
|
@jeffpaul and @dinhtungdu To closing the loop, we created two changes:
|
Fixes #6623
Notes
This PR aims to generate a ZIP file of the current PR so that this (development) version can be installed using the custom WP-CLI command
woo-test-environment.Testing
User Facing Testing
wp woo-test-environment setup --blocks={ZIP-FILE-URL}{ZIP-FILE-URL}, as mentioned in step 6. can be found in the comment of the PR as created in step 3.