This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
All Products block: Migrate to block.json #6754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
status: needs review
type: refactor
|
The release ZIP for this PR is accessible via: |
ockham
commented
Jul 26, 2022
Comment on lines
77
to
109
|
|
||
| /** | ||
| * Register and run the "All Products" block. | ||
| */ | ||
| registerBlockType( 'woocommerce/all-products', { | ||
| ...blockSettings, | ||
| /** | ||
| * Deprecation rule to handle the previous default rows which was 1 instead of 3. | ||
| */ | ||
| deprecated: [ | ||
| { | ||
| attributes: Object.assign( {}, blockSettings.attributes, { | ||
| rows: { type: 'number', default: 1 }, | ||
| } ), | ||
| save( { attributes } ) { | ||
| const data = { | ||
| 'data-attributes': JSON.stringify( attributes ), | ||
| }; | ||
| return ( | ||
| <div | ||
| className={ getBlockClassName( | ||
| 'wc-block-all-products', | ||
| attributes | ||
| ) } | ||
| { ...data } | ||
| > | ||
| <InnerBlocks.Content /> | ||
| </div> | ||
| ); | ||
| }, | ||
| }, | ||
| ], | ||
| } ); |
There was a problem hiding this comment.
I believe that this is no longer needed -- see PR description:
( [...] rely on server-side registration via
register_block_type_from_metadatahere) thanks to the existingAllProducts.phpfile and class
There was a problem hiding this comment.
You still need to register client-specific settings with registerBlockType. I don't think you need to export anything from this file. Depending on the lowest supported WP version you only need to call:
import metadata from './block.json';
registerBlockType( metadata.name, settings );or
import metadata from './block.json';
registerBlockType( metadata, settings );In case some settings aren't handled in older versions of WP.
|
The release ZIP for this PR is accessible via: |
|
Size Change: +179 B (0%) Total Size: 878 kB
ℹ️ View Unchanged
|
2 tasks
Aljullu
requested review from
a team,
danielwrobert and
albarin
and removed request for
a team,
Aljullu and
danielwrobert
|
The release ZIP for this PR is accessible via: |
albarin
reviewed
Jul 27, 2022
albarin
suggested changes
Jul 27, 2022
albarin
approved these changes
Jul 27, 2022
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
ockham
force-pushed
the
update/all-products-block-json
branch
from
28561d3 to
ae38915
Compare
|
Ah, please don't merge yet, I just noticed that I'm getting a block validation error if I have a pre-existing All Products block (added on
|
|
Looking at the difference between "Content generated by |
|
I think the solution is to set Since we're not doing that (yet), the block parser mis-interprets this wrapping By setting the |
|
It seems that JS unit tests are still failing, but that seems unrelated: #6780. |
ockham
force-pushed
the
update/all-products-block-json
branch
from
630deee to
9c5c24c
Compare
|
I can't seem to merge this. Could someone else (with sufficient privileges) please do that on my behalf? 🙌 |
Aljullu
added
type: technical debt
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By-product of this experiment.
This shouldn't have any user-facing changes; it's merely a refactor to use
block.json(and rely on server-side registration viaregister_block_type_from_metadatahere) thanks to the existingAllProducts.phpfile and class).Testing
Verify that the "All Products" block still works as before, both in the editor and on the frontend.
Make sure that both existing instances of the block continue to work (and respect their attributes), and that newly inserting an "All Products" block also works.
Changelog
All Products block: Migrate to block.json