This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Clean the top-level of the /build folder #7047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
opr
and removed request for
a team
|
The release ZIP for this PR is accessible via: |
tarhi-saad
added
tools
|
Size Change: 0 B Total Size: 934 kB ℹ️ View Unchanged
|
The Inner Blocks' metadata lives now in the `/build/inner-blocks`. But, the function `get_block_metadata_path` was only looking for metadata inside the top-level of the `build/` folder
opr
approved these changes
Sep 16, 2022
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
* Generate Inner Blocks' JSON files in a common folder * Get the correct metadata path for the Inner Blocks The Inner Blocks' metadata lives now in the `/build/inner-blocks`. But, the function `get_block_metadata_path` was only looking for metadata inside the top-level of the `build/` folder
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are filtering the
Inner Blocksby checking theparentfield of the JSON metadata. If aparentfield is defined then it's definitely anInner Block.We chose the simple solution of generating all of our Inner Blocks' JSON files in a single folder called
inner-blocks. This solution will clean the/buildfolder and allow us to support any newly createdInner Blocksby default, eliminating the need to manually fix them (e.g., Generating JSON files inside amini-cart,cart-blocks,checkout-blocks, etc. folders).Fixes #6972
Accessibility
prefers-reduced-motionOther Checks
Screenshots
Testing
To test this PR:
clean/6972-build-folderbranchnpm run build./buildfolder. Check that there aren't any generated Inner Blocks folders (e.g.,cart-items-block,checkout-totals-block, etc.). Additionally, ensure that theinner-blocksfolder was created./build/inner-blocksfolder. Check that the Inner Blocks folders with theirblock.jsonfiles were generated (Please see image below).User Facing Testinginstructions, and ensure that the translations are still working as expectedAutomated Tests
User Facing Testing
title&descriptionare translated in the inspector. See image below:WooCommerce Visibility
Performance Impact