This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Custom validation messages using the field name/label #8143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
status: needs review
block: checkout
woocommercebot
requested review from
a team and
opr
and removed request for
a team
mikejolley
commented
Jan 10, 2023
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +75 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
opr
suggested changes
Jan 11, 2023
There was a problem hiding this comment.
Thanks Mike, what you've done looks and works great, but could we add unit tests for getValidityMessageForInput please, and possibly an integration test for ValidatedTextInput to ensure the correct values are being passed to setValidationErrors? (If you think that's necessary). I can help with this if needed.
mikejolley
force-pushed
the
update/field-validation-messages-7729
branch
from
6755c33 to
43e37eb
Compare
|
Remaining fails are unrelated so ready for review @opr |
opr
approved these changes
Jan 13, 2023
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
gigitux
added
type: refactor
7 tasks
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a new helper function called
getValidityMessageForInput, which is passed the field label. Thevalidityof the field can then be used to generate a custom error message, in this case:This is then used to create an appropriate validation message.
Fixes #7729
Other Checks
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog