This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Experiment: Add a simple price filter block with directives #8218
Closed
DAreRodz
wants to merge
18
commits into
woocommerce:trunk
from
SantosGuillamot:try/add-simple-price-filter-block
Closed
Experiment: Add a simple price filter block with directives #8218
DAreRodz
wants to merge
18
commits into
woocommerce:trunk
from
SantosGuillamot:try/add-simple-price-filter-block
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A plugin for optional chaining is required as the repo uses Webpack 4 for now.
Co-authored-by: Luis Herranz <luisherranz@users.noreply.github.com>
6 tasks
Closed in favor of #8221 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a simple reimplementation of the Price Filter block using directives to filter a list of products by price.
Tracking issue: woocommerce/woocommerce#42486
Why?
The idea is to test and showcase how a block to filter a list of products would be implemented with directives. Also, to ease a future transition to this new API in case it finally becomes standard.
How?
This PR continues the work on #8026 and implements a new block called Simple Price Filter. The most interesting changes are in:
Next steps