This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Move notices to corresponding context #8228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… .editorconfig file enforces 2 spaces.
Jobs renaming.
nielslange
added
type: enhancement
woocommercebot
requested review from
a team and
wavvves
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +97 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
nielslange
commented
Jan 18, 2023
There was a problem hiding this comment.
@alexflorisca During our call yesterday, you suggested changing context to errorMessageContext to increase the readability. I noticed that createErrorNotice() expects that parameter to be called context. To use errorMessageContext instead, we'd have to apply the following changes:
Change
errorMessageContext: 'wc/checkout/payments',
Change
errorMessageContext
Change
woocommerce-blocks/assets/js/data/checkout/thunks.ts
Lines 73 to 80 in d374528
response.forEach(
( {
errorMessage,
validationErrors,
errorMessageCcontext = 'wc/checkout',
} ) => {
createErrorNotice( errorMessage, {
context: errorMessageContext,
} );
setValidationErrors( validationErrors );
}
);With that in mind, I find the current implementation easier to read, but I'm keen to hearing your thoughts on that.
…f github.com:woocommerce/woocommerce-blocks into 7731-remove-hardcoded-payment-notice # Conflicts: # .github/workflows/unit-tests.yml # package-lock.json
|
Yep you're right @nielslange , let's leave it as it is. |
…commerce/woocommerce-blocks into 7731-remove-hardcoded-payment-notice # Conflicts: # docs/third-party-developers/extensibility/checkout-payment-methods/payment-method-integration.md
3 tasks
nielslange
added
the
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7731
Currently, the error message
There was a problem with your payment option.appears above the Checkout block. In #7711, @mikejolley added new contexts forStoreNoticesContainer. This issue introduces the following changes:There was a problem with your payment option.fromwc/checkouttowc/checkout/payments.There was a problem with your shipping option.fromwc/checkouttowc/checkout/shipping-methods.__internalEmitValidateEventto exceptcontextas an optional parameter.Additional notes
As mentioned before, this PR introduces
contextas an optional parameter, which enables us (and 3PD) to define in which context an error message shall appear.Screenshots
There was a problem with your payment option.
There was a problem with your shipping option.
Testing
User Facing Testing
/assets/js/base/context/providers/cart-checkout/checkout-processor.tsand changeto
Place Orderand verify that the error messageThere was a problem with your payment option.appears within thePayment optionssection./assets/js/base/context/providers/cart-checkout/checkout-processor.tsand changeto
Place Orderand verify that the error messageThere was a problem with your shipping option.appears within theShipping optionssection.WooCommerce Visibility