-
Notifications
You must be signed in to change notification settings - Fork 219
All Products: Re-add alignment controls for Product Rating and Price #8264
Conversation
The release ZIP for this PR is accessible via:
Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: +18.1 kB (+2%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, @danieldudzic and sorry for the delay. The code works alright, however, the blocks are aligned on the center by default, but when adding the block for the first time and checking the alignment toolbar, none of the options are selected.
It feels like the correct option should be selected, no?
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
@sunyatasattva I've updated the default values for these elements so they are now selected like expected. e9f3320 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this, Tom! Works for me!
Nice work getting this old chestnut fixed @danieldudzic @tjcafferkey 🙌! |
Checking |
Since #8140 fixed the issue with All Products not saving settings correctly, this PR re-adds alignment settings for Product Rating and Product Price inside of the All Products block.
Fixes #3049
Screenshots
Testing
User Facing Testing
Alignment
toolbar option is available for both blocks and works correctly (both in the editor and the frontend).WooCommerce Visibility
Changelog