This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix noticeContext declaration in the Shipping calculator #8495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the declaration of noticeContext to make notice appear in the shipping calculator
woocommercebot
requested review from
a team and
mikejolley
and removed request for
a team
tarunvijwani
added
status: needs review
type: bug
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -10 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
tarunvijwani
deleted the
fix/broken-shipping-calculator-noticeContext-declaration
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declaration of
noticeContextin shipping calculator file was missing resulting in console error.With this PR, we fix the declaration of
noticeContextand make error notice appear in the shipping calculatorChanges in the PR:
Screenshots
Testing
Automated Tests
User Facing Testing
1.Add a product to the cart.
2. Go to the Cart block page.
3. Open the shipping calculator.
4. Enter any address with an invalid zip code.
5. Confirm the error notice is getting displayed in the calculator.
6. Confirm there are no errors in the browser console.
WooCommerce Visibility
Changelog