This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
inject hooks on the first block after the main div wrapper #8702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
added
type: bug
woocommercebot
requested review from
a team and
imanish003
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
gigitux
force-pushed
the
fix/compatibility-layer-first-block
branch
from
0c5b614 to
fc2dd50
Compare
|
Size Change: 0 B Total Size: 1.12 MB ℹ️ View Unchanged
|
|
hey @gigitux ! ref.:
Do you mind clarifying which markup is supposed to be inserted? The link is currently pointing to a local install. Thanks! |
Ops. I fixed the link! I created a GIF that shows how do this: Screen.Capture.on.2023-03-13.at.14-38-53.mov |
imanish003
approved these changes
Mar 14, 2023
imanish003
reviewed
Mar 14, 2023
nefeline
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Thanks for updating the instructions: nice work!
Test results:
Go to the Single Product Template.
Edit the template via code and insert this markup via the code editor
Save.
Be sure that the Single Product Template is visible correctly.
✅ Confirmed the template is visible in the editor:
✅ Confirmed the template is also properly displayed on the FE:
Create a new snippet and copy-paste this gist.
Check that those hooks are put AFTER the div wrapper:
✅ Confirmed they are displayed after the wrapper div:
|
Thanks for the review, folks! @imanish003 I will merge this PR, if you have some doubts feel free to continue the discussion in this PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During some tests, I noticed that the hooks on the first block are added before the
<div>wrapper that we added to keep the compatibility with WC Core CSS.This PR fixes this wrong behavior.
Fixes #8701
Screenshots
Testing
User Facing Testing
WooCommerce Visibility