Update tracking for blocks #311
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,16 +2,10 @@ import { __ } from '@wordpress/i18n'; | |
| import { | ||
| getProductFieldObject, | ||
| getProductImpressionObject, | ||
| getProductId, | ||
| formatPrice, | ||
| } from './utils'; | ||
|
|
||
| /** | ||
| * Tracks view_item_list event | ||
| * | ||
|
|
@@ -23,17 +17,19 @@ export const trackListProducts = ( { | |
| products, | ||
| listName = __( 'Product List', 'woocommerce-google-analytics-integration' ), | ||
| } ) => { | ||
| if ( products.length > 0 ) { | ||
| trackEvent( 'view_item_list', { | ||
| item_list_id: 'engagement', | ||
| item_list_name: __( | ||
| 'Viewing products', | ||
| 'woocommerce-google-analytics-integration' | ||
| ), | ||
| items: products.map( ( product, index ) => ( { | ||
| ...getProductImpressionObject( product, listName ), | ||
| index: index + 1, | ||
| } ) ), | ||
| } ); | ||
| } | ||
| }; | ||
|
|
||
| /** | ||
|
|
@@ -45,11 +41,6 @@ export const trackListProducts = ( { | |
| */ | ||
| export const trackAddToCart = ( { product, quantity = 1 } ) => { | ||
| trackEvent( 'add_to_cart', { | ||
| items: [ getProductFieldObject( product, quantity ) ], | ||
| } ); | ||
| }; | ||
|
|
@@ -63,11 +54,6 @@ export const trackAddToCart = ( { product, quantity = 1 } ) => { | |
| */ | ||
| export const trackRemoveCartItem = ( { product, quantity = 1 } ) => { | ||
| trackEvent( 'remove_from_cart', { | ||
| items: [ getProductFieldObject( product, quantity ) ], | ||
| } ); | ||
| }; | ||
|
|
@@ -91,70 +77,55 @@ export const trackChangeCartItemQuantity = ( { product, quantity = 1 } ) => { | |
| }; | ||
|
|
||
| /** | ||
| * Track begin_checkout event | ||
| * | ||
| * @param {Object} params The function params | ||
| * @param {Object} params.storeCart The cart object | ||
| */ | ||
| export const trackBeginCheckout = ( { storeCart } ) => { | ||
| trackEvent( 'begin_checkout', { | ||
| currency: storeCart.totals.currency_code, | ||
| value: formatPrice( | ||
| storeCart.totals.total_price, | ||
| storeCart.totals.currency_minor_unit | ||
| ), | ||
| coupon: storeCart.coupons[ 0 ]?.code || '', | ||
|
There was a problem hiding this comment. ❔ There was a problem hiding this comment. That's a good point. I'm not sure what the behavior would be and from a quick search I couldn't find any thing in the GA documentation about it 🤔 I've updated how it works in 813b7ee so we're not including an empty string. |
||
| items: storeCart.items.map( getProductFieldObject ), | ||
| } ); | ||
| }; | ||
|
|
||
| /** | ||
| * Track add_shipping_info event | ||
| * | ||
| * @param {Object} params The function params | ||
| * @param {Object} params.storeCart The cart object | ||
| */ | ||
| export const trackShippingTier = ( { storeCart } ) => { | ||
| trackEvent( 'add_shipping_info', { | ||
| currency: storeCart.totals.currency_code, | ||
| value: formatPrice( | ||
| storeCart.totals.total_price, | ||
| storeCart.totals.currency_minor_unit | ||
| ), | ||
| coupon: storeCart.coupons[ 0 ]?.code || '', | ||
| shipping_tier: | ||
| storeCart.shippingRates[ 0 ]?.shipping_rates?.find( | ||
| ( rate ) => rate.selected | ||
| )?.name || '', | ||
| items: storeCart.items.map( getProductFieldObject ), | ||
| } ); | ||
| }; | ||
|
|
||
| /** | ||
| * Tracks select_content event. | ||
| * | ||
| * @param {Object} params The function params | ||
| * @param {Object} params.product The product to track | ||
| */ | ||
| export const trackSelectContent = ( { product } ) => { | ||
| trackEvent( 'select_content', { | ||
| content_type: 'product', | ||
| content_id: getProductId( product ), | ||
| } ); | ||
| }; | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📜 💅
If I understand the docs correctly, this id is to identify the list from which we're reporting.
With blocks, we can have multiple lists on different pages. But currently, we send
engagementregardless of which list we track. Maybe we could somehow forward the block instance id, or at least page ID?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be a nice addition! I've opened issue #324 so as to not get off track in this PR.