Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] Extract items code from aggregate model #14498

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

joshheald
Copy link
Contributor

@joshheald joshheald commented Nov 22, 2024

Closes: #14496

Description

In this PR we extract the Item list code to a service.

It's quite large but almost all of that is a lift-and-shift of the tests.

Testing information

The main things to check are item list functions – initial loading, pull to refresh, pagination, and error states. However, none of the code has really changed to enable us to extract it, it's close to a pure lift-and-shift.

I tested on an iPad Air running iOS 17.7

Screenshots

extract-items-code-to-service.mp4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@joshheald joshheald added type: task An internally driven task. feature: POS labels Nov 22, 2024
@joshheald joshheald added this to the 21.3 milestone Nov 22, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 22, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14498-245fa7e
Version21.2
Bundle IDcom.automattic.alpha.woocommerce
Commit245fa7e
App Center BuildWooCommerce - Prototype Builds #11736
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Base automatically changed from task/tidy-small-issues-in-aggregate-model-and-entry-view to trunk November 22, 2024 15:32
@joshheald joshheald changed the title Issue/14496 extract items code from aggregate model [Woo POS] Extract items code from aggregate model Nov 22, 2024
@joshheald joshheald marked this pull request as ready for review November 22, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: POS type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Woo POS] Extract item list service
2 participants