Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear Action Scheduler Transients #152

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Clear Action Scheduler Transients #152

merged 1 commit into from
Jul 21, 2020

Conversation

dhruvins
Copy link
Contributor

Currently when Clear Transients action is performed via System Tools, the Action Scheduler Transients are not cleared resulting in incorrect comment counts.

Also Fixes woocommerce/woocommerce#25750

@dhruvins
Clear Action Scheduler Transients
b958517 
Currently when Clear Transients action is performed via System Tools, the Action Scheduler Transients are not cleared resulting in incorrect comment counts.
@Konamiman Konamiman mentioned this pull request Mar 23, 2020
Closed
claudiosanches
claudiosanches approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@claudiosanches claudiosanches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help!

@claudiosanches claudiosanches added the status: approved PRs that have been approved and ready to be merged. label Jun 26, 2020
vedanshujain
vedanshujain approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@vedanshujain vedanshujain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vedanshujain vedanshujain merged commit fe2c027 into woocommerce:master Jul 21, 2020
@vedanshujain vedanshujain added needs cherry picking Commits from this PR also needs to be added to current release branch. status: needs changelog Mark all PRs that have not had their changelog entries added. [auto] and removed needs cherry picking Commits from this PR also needs to be added to current release branch. labels Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vedanshujain vedanshujain vedanshujain approved these changes

@claudiosanches claudiosanches claudiosanches approved these changes

Assignees
No one assigned
Labels
status: approved PRs that have been approved and ready to be merged. status: needs changelog Mark all PRs that have not had their changelog entries added. [auto]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clear transients should clear AS transients as well
3 participants
@dhruvins @claudiosanches @vedanshujain