Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiarch build #8

Merged
merged 9 commits into from
Dec 18, 2021
Merged

Multiarch build #8

merged 9 commits into from
Dec 18, 2021

Conversation

jasonlearst
Copy link
Contributor

@jasonlearst jasonlearst commented Nov 22, 2021 •
edited by anbraten
Loading

I was looking for a way to run the Woodpecker agent on my Raspberry Pi. The first issue I had was that the plugin-git is not currently built for ARM. I was looking for a way to build my own and made these modifications to use Docker buildx to create a Multi-arch build.

I saw issue #3 and thought this was a good first step.

closes #3

@jasonlearst
Copy link
Contributor Author

The docker image plugin/base did not support ppc64le, but it's base alpine does. With commit bf68209 I chose to bypass plugin/base as the base image and instead build from alpine directly. I merged the 'apk add' command with the packages that plugin/base and woodpecker-ci/plugin-git were including.

6543
6543 reviewed Dec 13, 2021
View reviewed changes
Makefile Show resolved Hide resolved
anbraten
anbraten reviewed Dec 13, 2021
View reviewed changes
.woodpecker.yml Outdated Show resolved Hide resolved
anbraten
anbraten reviewed Dec 13, 2021
View reviewed changes
docker/Dockerfile.multiarch Outdated Show resolved Hide resolved
docker/Dockerfile.multiarch Outdated Show resolved Hide resolved
docker/Dockerfile.multiarch Outdated Show resolved Hide resolved
docker/Dockerfile.multiarch Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@jasonlearst
Copy link
Contributor Author

With some minor changes I was able to get the woodpecker/plugin-docker-buildx image created. I tested it locally on my machine and it was able to build the plugin-git image for multiple architectures.

@anbraten
Copy link
Member

Thanks for the adjustments to woodpeckerci/plugin-docker-buildx. We fixed the CI for it, so a new image is now online on docker hub.

@6543 6543 added the enhancement New feature or request label Dec 18, 2021
@6543 6543 added this to the v1.1.0 milestone Dec 18, 2021
6543
6543 reviewed Dec 18, 2021
View reviewed changes
.dockerignore Show resolved Hide resolved
6543
6543 reviewed Dec 18, 2021
View reviewed changes
.woodpecker.yml Outdated Show resolved Hide resolved
@6543 6543 requested a review from anbraten December 18, 2021 20:56
anbraten
anbraten approved these changes Dec 18, 2021
View reviewed changes
Copy link
Member

@anbraten anbraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@6543 6543 merged commit bf3c82a into woodpecker-ci:master Dec 18, 2021
6543 added a commit that referenced this pull request Dec 18, 2021
@6543
Changelog for v1.1.0 (#10)
5e0b152 
* FEATURES
  * Add ppc64le support (#8)
* BUGFIXES
  * Regognize "CI_*" EnvVars (#6)
* ENHANCEMENTS
  * Multiarch build (#8)
* MISC
  * Upgrade urfave/cli to v2 (#5)
@6543 6543 mentioned this pull request Dec 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@6543 6543 6543 approved these changes

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Release MultiArch
3 participants
@jasonlearst @anbraten @6543