Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organizations tab for admins #2307

Closed
4 tasks done
qwerty287 opened this issue Aug 21, 2023 Discussed in #2257 · 9 comments · Fixed by #2338
Closed
4 tasks done

Organizations tab for admins #2307

qwerty287 opened this issue Aug 21, 2023 Discussed in #2257 · 9 comments · Fixed by #2338
Labels
enhancement improve existing features

Comments

@qwerty287
Copy link
Contributor

Discussed in #2257

Originally posted by lonix1 July 10, 2023

Clear and concise description of the problem

The server config page shows tabs: "Secrets", "Users", "Agents" and "Queue".

There should be another tab, "Organizations".

There are various org-level settings, e.g. organization secrets (exposed by the API), but they aren't viewable in the UI. So they are effectively "hidden" and it's easy to forget about it.

Suggested solution

A new tab named "Organizations".

Doesn't need to be complicated, or to allow interaction. Only to show the orgs, and secrets related to them. Readonly to keep it simple.

Alternative

No response

Additional context

No response

Validations

  • Checked that the feature isn't part of the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
  • Read the Contributing Guidelines.
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@qwerty287 qwerty287 added the enhancement improve existing features label Aug 21, 2023
@qwerty287 qwerty287 mentioned this issue Aug 21, 2023
14 tasks
@anbraten
Copy link
Member

anbraten commented Aug 21, 2023

There are some open questions to me. First of all what's the purpose of this list. Should it provide extra admin settings like the users list like restricting orgs in the future or is it an overview redirecting to the org settings or repo list page? One thing to always keep in mind is also that there are often two different hosting kinds:

  • I am an admin of the instance and also the main user and therefore owner of almost all orgs and repos
  • I am just the admin of a large instance used by many different independent users and orgs and I am mainly curious about a working instance and healthy community

Especially the second type would currently not really benefit from having a look at the secrets from others and the first admin could already open the orgs page to get to the secrets.

@anbraten
Copy link
Member

Maybe a redesign of the home page (currently list of repos the user is a member if) which shows the own repos and also the own orgs would help.

@anbraten
Copy link
Member

@lonix1 Could be your main issue that you want to find your own orgs? Maybe sth like #2308 is actually what you need.

@qwerty287
Copy link
Contributor Author

qwerty287 commented Aug 21, 2023

While the purpose was another in the beginning, I think this is about being able to list all orgs as admin - just like you can do with users. I think that's a totally valid suggestion without any discussion necessary

@anbraten
Copy link
Member

I am currently against adding it until the purpose is clearly defined. It's still not clear from the description and discussion how the user will interact with the list.

I can image it will look somehow like the users list:
image

But that's just an idea and might not solve the issue OP had.

@qwerty287
Copy link
Contributor Author

qwerty287 commented Aug 21, 2023

Yes, that's an idea.

But why is the purpose unclear? What's the purpose of the user admin list? It's kind of the same.
This is a central place to see all orgs, not only the ones you belong to.

@anbraten
Copy link
Member

anbraten commented Aug 21, 2023

The users list has some action, delete user, make an user an admin which can only be done by an admin. The orgs page wont offer such a feature and is only listing orgs and redirecting to existing pages. I think the issue of OP is to find his own orgs and their settings and not the orgs of the whole instance. In case of large instances (imagine codeberg, a company) why would an admin want to access an org of someone else and change someones secrets.

@qwerty287
Copy link
Contributor Author

It's not necessary to provide actions there, links are fine, but the main purpose is viewing all orgs and getting an overview over them. This could be useful for e.g. companies that use multiple orgs. Also, this can be extended with actions like delete too.

@lonix1
Copy link
Contributor

lonix1 commented Aug 21, 2023

My problem was different (I didn't know there is an orgs page with orgs secrets, but qwerty showed me how).

But you asked for my 2c...

I agree with qwerty "being able to list all orgs as admin - just like you can do with users" is nice. The same in gitea, the server admin page has tabs for "User Accounts", "Organizations", "Repositories", "Packages", i.e. an admin can see everything inside his server. It doesn't need to expose functionality though - it could be readonly.

Also "useful for e.g. companies that use multiple orgs" - my instance is for a small company and even we already have 4 orgs - two for products, one for FOSS, one for "other".

Also I like abraten's design, it is simple and fits in with the existing UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants