Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PR closed event #286

Closed
anbraten opened this issue Aug 30, 2021 · 1 comment · Fixed by #2684
Closed

Support PR closed event #286

anbraten opened this issue Aug 30, 2021 · 1 comment · Fixed by #2684
Labels
feature add new functionality
Milestone

Comments

@anbraten
Copy link
Member

To support something like review environments it would be nice to be able to listen on PR closed events. This would allow to start and update a review environment in the moment a PR is created or someone pushed to it and destroy it after the PR has been closed or merged.

@anbraten anbraten changed the title Support PR closed events Support PR closed event Aug 30, 2021
@anbraten anbraten added the feature add new functionality label Sep 16, 2021
@anbraten anbraten added this to the 0.16.0 milestone Oct 13, 2021
@anbraten anbraten mentioned this issue Apr 4, 2022
31 tasks
@anbraten
Copy link
Member Author

anbraten commented May 3, 2022

We should think about how we add additional events types in the future as it would be at least possible to add following events:

  • release (type: draft, pre, stable; action: created, updated, deleted)
  • comment (create, delete, update)
  • deployment
  • label (added, removed, issue, PR)
  • pr (created, updated, closed)
  • issues (created, updated, closed, reopened)
  • push to branch
  • tag
  • manual / web
  • cron

Should it for example be one event release with some env var like CI_RELEASE_TYPE=draft or should we add multiple events for it like release_stable, release_draft and release_pre. Same thing applies for possible events like pr, comment and label

@qwerty287 qwerty287 removed this from the 1.0.0 milestone May 28, 2023
@pat-s pat-s added this to the 1.1.0 milestone Jul 11, 2023
@anbraten anbraten moved this to Backlog in next release Aug 30, 2023
@pat-s pat-s modified the milestones: 2.0.0, 2.x.x Oct 13, 2023
6543 pushed a commit that referenced this issue Dec 26, 2023
- [x] updates docs
- [x] adjust UI
  - [x] show correct icon
  - [x] show correct link (to pr)
  - [x] add as option in secret edit
- [x] parse webhook
- [x] update tests
  - [x] github merged
  - [x] github closed
  - [x] gitea merged
  - [x] gitea closed
  - [x] bitbucket merged
  - [x] bitbucket closed
  - [x] gitlab merged
  - [x] gitlab closed

closes #286
@github-project-automation github-project-automation bot moved this from Backlog to Done in next release Dec 26, 2023
@qwerty287 qwerty287 modified the milestones: 3.x.x, 2.1.0 Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature add new functionality
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants