Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variable names are silently changed to SCREAMING_SNAKE_CASE #3515

Closed
3 tasks done
terminalnode opened this issue Mar 20, 2024 · 2 comments · Fixed by #3516
Closed
3 tasks done

Environment variable names are silently changed to SCREAMING_SNAKE_CASE #3515

terminalnode opened this issue Mar 20, 2024 · 2 comments · Fixed by #3516
Labels
bug Something isn't working

Comments

@terminalnode
Copy link

Component

agent

Describe the bug

Our app uses the environment variable naming schema application_name.property_name, e.g. matrix.environment='test'. In 2.3.0 this worked fine, but as of 2.4.0 this is being silently changed to MATRIX_ENVIRONMENT='test', which our app isn't recognizing. I can't find any option to disable this behavior in the documentation.

While I do understand that the screaming snake case is much more common than what we're using, ours is still a valid environment variable name and silently correcting it like this is causing us a ton of headache.

System Info

{"source":"https://github.com/woodpecker-ci/woodpecker","version":"2.4.0"}

Additional context

No response

Validations

  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
@terminalnode terminalnode added the bug Something isn't working label Mar 20, 2024
@qwerty287
Copy link
Contributor

Sorry, that's a bug and wasn't intended… #3516 fixes it

@terminalnode
Copy link
Author

Thanks for addressing this so quickly. 🙂

lafriks pushed a commit that referenced this issue Mar 20, 2024
closes #3515 

I think after this is fixed, we should publish a new release as this can
be quite important.

Co-authored-by: Robert Kaussow <mail@thegeeklab.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants