support nested repositories (GitLab)

[jdoubleu]

Component: server

Describe the bug

It looks like Woodpecker does not properly handle nested repositories from GitLab. Nested repositories or subgroups are a GitLab feature where a repository might exist inside a 2 level or greater hierarchy (e.g. my-org-group/team-group/category-group/actual-repository.git), as opposed to the 2 level hierarchy that is well established by SCMs (e.g. vendor/project.git).

When I try to sync my repositories in the Woodpecker UI, nothing happens. Looking that the debug error logs I get the following message:

{"level":"debug","time":"2021-12-31T17:45:34+01:00","message":"sync error: my-user: could not fetch permission of repo 'rootgroup/subgroup/my-repository': GET https://gitlab-instance.com/api/v4/projects/rootgroup/subgroup: 404 {message: 404 Project Not Found}"}

As you can see, Woodpecker is querying the wrong API endpoint:

- https://gitlab-instance.com/api/v4/projects/rootgroup/subgroup
+ https://gitlab-instance.com/api/v4/projects/rootgroup/subgroup/my-repository

I think there are two issues here, which can be resolved independently:

1. The complete repository sync fails/stops when only one repository fails to sync. I think Woodpecker should continue syncing the repositories and just skip the failed ones. It would be useful to display an error message to the user in that case.
2. Properly handle nested repositories. This might be harder to accomplish because they might need to be mapped to the tradition 2 level hierarchy as that's used internally?

References

@6543 pointed out, they had replaced the GitLab API client with github.com/xanzy/go-gitlab in recent master.

• https://github.com/woodpecker-ci/woodpecker/blob/master/server/remote/gitlab/gitlab.go#L199-L207

System Info

next-d11b2bb8
built from master@d11b2bb8e5bea6f29f82a20815ef7bf3fa96a0a2

[qwerty287]

I'm not sure if we should close this. The corresponding PR #1078 didn't target it and I didn't test it.

[bck01215]

Still experiencing errors with nested repositories on latest docker build

[anbraten]

@bck01215 Cloud you give next a try. Latest is our latest stable release which does not include those unreleased changes from master.

[bck01215]

I'm still getting the following debug message in the next repo

Skipping nested repository nested-repo for user username, because they are not supported, yet (see #648)."}

[anbraten]

I guess we have to introduce #1295 somehow to solve it.