Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type of 'log_data' from blob to longblob #1050

Merged
merged 5 commits into from
Jul 29, 2022

Conversation

simmstein
Copy link
Contributor

fix #1022

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022

Codecov Report

Merging #1050 (822406f) into master (d2556a0) will decrease coverage by 0.75%.
The diff coverage is 0.00%.

❗ Current head 822406f differs from pull request most recent head 472921e. Consider uploading reports for the commit 472921e to get more accurate results

@@            Coverage Diff             @@
##           master    #1050      +/-   ##
==========================================
- Coverage   51.27%   50.52%   -0.76%     
==========================================
  Files          81       81              
  Lines        6157     6249      +92     
==========================================
  Hits         3157     3157              
- Misses       2817     2909      +92     
  Partials      183      183              
Impacted Files Coverage Δ
server/model/perm.go 0.00% <ø> (ø)
server/remote/bitbucket/bitbucket.go 86.87% <0.00%> (-2.43%) ⬇️
server/remote/bitbucketserver/bitbucketserver.go 0.00% <0.00%> (ø)
server/remote/coding/coding.go 63.84% <0.00%> (-0.92%) ⬇️
server/remote/gitea/gitea.go 35.38% <0.00%> (-1.86%) ⬇️
server/remote/github/github.go 15.71% <0.00%> (-0.31%) ⬇️
server/remote/gitlab/gitlab.go 24.31% <0.00%> (-2.64%) ⬇️
server/remote/gogs/gogs.go 52.73% <0.00%> (-3.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9e1de3...472921e. Read the comment docs.

@6543
Copy link
Member

6543 commented Jul 29, 2022

@simmstein only a migration is missing, would you mind to add it?

https://woodpecker-ci.org/docs/development/guides#add-a-new-migration

if you need help please tell us

@6543 6543 added the bug Something isn't working label Jul 29, 2022
@6543 6543 added this to the 1.0.0 milestone Jul 29, 2022
@6543 6543 added the backport-done indicates that this pull has been backported label Jul 29, 2022
@simmstein
Copy link
Contributor Author

simmstein commented Jul 29, 2022

First try in go-lang 🙂 I had the migration task.

Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@6543 6543 merged commit 6351684 into woodpecker-ci:master Jul 29, 2022
@6543
Copy link
Member

6543 commented Jul 29, 2022

@simmstein would you mind backporting it?

-> just cherry-pick the merge commit onto release branch

simmstein added a commit to simmstein/woodpecker that referenced this pull request Jul 29, 2022
* Update type of 'log_data' from blob to longblob

* Add migration task to update log_data type
6543 pushed a commit that referenced this pull request Jul 29, 2022
Backport #1050

* Update type of 'log_data' from blob to longblob
* Add migration task to update log_data type
qwerty287 pushed a commit that referenced this pull request Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done indicates that this pull has been backported bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log_data should be a LONGBLOB
3 participants