On Repo update, keep old "Clone" if update would empty it (#1170) #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-ci#1170) fixed woodpecker-ci#1169 after debugging, I found that: if `Clone` in database is empty, before https://github.com/woodpecker-ci/woodpecker/blob/master/server/api/hook.go#L128, the `repo.Clone` be always unset, so clone is failed. This PR makes the empty `Clone` can't overwrite the value in database.
qwerty287
approved these changes
Sep 18, 2022
|
Tests are failing. |
|
well but unrelated |
|
Still fails, but yes, it's unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #1169
after debugging, I found that:
if
Clonein database is empty, beforehttps://github.com/woodpecker-ci/woodpecker/blob/master/server/api/hook.go#L128, the
repo.Clonebe always unset, so clone is failed.This PR makes the empty
Clonecan't overwrite the value in database.