Global and organization registries #1672

lafriks · 2023-03-23T00:07:44Z

Adds way to add server wide and organization wide registries

Closes #1448

Global registry list (including system read-only registries):

Organization registry list:

codecov-commenter · 2023-03-23T13:27:17Z

Codecov Report

Attention: Patch coverage is 20.58824% with 27 lines in your changes missing coverage. Please review.

Project coverage is 39.10%. Comparing base (2fa9432) to head (c99d72b).
Report is 5 commits behind head on main.

❗ Current head c99d72b differs from pull request most recent head 5041d26

Please upload reports for the commit 5041d26 to get more accurate results.

Files	Patch %	Lines
server/store/datastore/registry.go	25.00%	20 Missing and 1 partial ⚠️
server/model/registry.go	0.00%	5 Missing ⚠️
server/pipeline/items.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1672       +/-   ##
===========================================
+ Coverage   28.19%   39.10%   +10.90%     
===========================================
  Files         367      167      -200     
  Lines       25734    10785    -14949     
===========================================
- Hits         7255     4217     -3038     
+ Misses      17816     6299    -11517     
+ Partials      663      269      -394

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lonix1 · 2023-07-30T16:00:17Z

Please consider also exposing the "global registries" in the UI. e.g. in the main settings UI.

woodpecker-bot · 2024-07-02T15:57:55Z

Deployment of preview was torn down

lafriks · 2024-07-03T00:28:30Z

Should be ready for review now

lafriks · 2024-07-03T00:56:50Z

lint failure not related to my changes

server/store/datastore/migration/common.go:198:64: `alterColumnNull` - `null` always receives `false` (unparam)
func alterColumnNull(sess *xorm.Session, table, column string, null bool) error {

server/model/registry.go

server/router/api.go

server/store/datastore/migration/032_registries_add_user.go

web/src/lib/api/types/registry.ts

web/src/views/admin/AdminSettings.vue

web/src/views/repo/RepoWrapper.vue

cli/registry/registry.go

Co-authored-by: Anbraten <6918444+anbraten@users.noreply.github.com>

cli/repo/registry/registry.go

qwerty287 · 2024-07-08T08:57:59Z

This PR misses two things:

user registries
show global/org registries in org/repo as read-only

## [2.7.0](https://github.com/woodpecker-ci/woodpecker/releases/tag/v2.7.0) - 2024-07-18 ### 🔒 Security - Add blocklist of environment variables who could alter execution of plugins [[#3934](#3934)] - Make sure plugins only mount the workspace base in a predefinde location [[#3933](#3933)] - Disallow to set arbitrary environments for plugins [[#3909](#3909)] - Use proper oauth state [[#3847](#3847)] - Enhance token checking [[#3842](#3842)] - Bump github.com/hashicorp/go-retryablehttp v0.7.5 -> v0.7.7 [[#3834](#3834)] ### ✨ Features - Gracefully shutdown server [[#3896](#3896)] - Gracefully shutdown agent [[#3895](#3895)] - Convert urls in logs to links [[#3904](#3904)] - Allow login using multiple forges [[#3822](#3822)] - Global and organization registries [[#1672](#1672)] - Cli get repo from git remote [[#3830](#3830)] - Add api for forges [[#3733](#3733)] ### 📈 Enhancement - Cli fix pipeline logs [[#3913](#3913)] - Migrate to github.com/urfave/cli/v3 [[#2951](#2951)] - Allow to change the working directory also for plugins and services [[#3914](#3914)] - Remove `unplugin-icons` [[#3809](#3809)] - Release windows binaries as zip file [[#3906](#3906)] - Convert to openapi 3.0 [[#3897](#3897)] - Enhance pipeline list [[#3898](#3898)] - Add user registries UI [[#3888](#3888)] - Sort users by login [[#3891](#3891)] - Exclude dummy backend in production [[#3877](#3877)] - Fix deploy task env [[#3878](#3878)] - Get default branch and show message in pipeline list [[#3867](#3867)] - Add timestamp for last work done by agent [[#3844](#3844)] - Adjust logger types [[#3859](#3859)] - Cleanup state reporting [[#3850](#3850)] - Unify DB tables/columns [[#3806](#3806)] - Let webhook pass on pipeline parsing error [[#3829](#3829)] - Exclude mocks from release build [[#3831](#3831)] - K8s secrets reference from step [[#3655](#3655)] ### 🐛 Bug Fixes - Handle empty repositories in gitea when listing PRs [[#3925](#3925)] - Update alpine package dep for docker images [[#3917](#3917)] - Don't report error if agent was terminated gracefully [[#3894](#3894)] - Let agents continuously report their health [[#3893](#3893)] - Ignore warnings for cli exec [[#3868](#3868)] - Correct favicon states [[#3832](#3832)] - Cleanup of the login flow and tests [[#3810](#3810)] - Fix newlines in logs [[#3808](#3808)] - Fix authentication error handling [[#3807](#3807)] ### 📚 Documentation - Streamline docs for new users [[#3803](#3803)] - Add mastodon verification [[#3843](#3843)] - chore(deps): update docs npm deps non-major [[#3837](#3837)] - fix(deps): update docs npm deps non-major [[#3824](#3824)] - Add openSUSE package [[#3800](#3800)] - chore(deps): update docs npm deps non-major [[#3798](#3798)] - Add "Docker Tags" Plugin [[#3796](#3796)] - chore(deps): update dependency marked to v13 [[#3792](#3792)] - chore: fix some comments [[#3788](#3788)] ### Misc - chore(deps): update web npm deps non-major [[#3930](#3930)] - chore(deps): update dependency vitest to v2 [[#3905](#3905)] - fix(deps): update module github.com/google/go-github/v62 to v63 [[#3910](#3910)] - chore(deps): update docker.io/woodpeckerci/plugin-docker-buildx docker tag to v4.1.0 [[#3908](#3908)] - Update plugin-git and add renovate trigger [[#3901](#3901)] - chore(deps): update docker.io/mstruebing/editorconfig-checker docker tag to v3.0.3 [[#3903](#3903)] - fix(deps): update golang-packages [[#3875](#3875)] - chore(deps): lock file maintenance [[#3876](#3876)] - [pre-commit.ci] pre-commit autoupdate [[#3862](#3862)] - Add dummy backend [[#3820](#3820)] - chore(deps): update dependency replace-in-file to v8 [[#3852](#3852)] - Update forgejo sdk [[#3840](#3840)] - chore(deps): lock file maintenance [[#3838](#3838)] - Allow to set dist dir using env var [[#3814](#3814)] - chore(deps): lock file maintenance [[#3805](#3805)] - chore(deps): update docker.io/lycheeverse/lychee docker tag to v0.15.1 [[#3797](#3797)]

Co-authored-by: Anbraten <6918444+anbraten@users.noreply.github.com>

## [2.7.0](https://github.com/woodpecker-ci/woodpecker/releases/tag/v2.7.0) - 2024-07-18 ### 🔒 Security - Add blocklist of environment variables who could alter execution of plugins [[woodpecker-ci#3934](woodpecker-ci#3934)] - Make sure plugins only mount the workspace base in a predefinde location [[woodpecker-ci#3933](woodpecker-ci#3933)] - Disallow to set arbitrary environments for plugins [[woodpecker-ci#3909](woodpecker-ci#3909)] - Use proper oauth state [[woodpecker-ci#3847](woodpecker-ci#3847)] - Enhance token checking [[woodpecker-ci#3842](woodpecker-ci#3842)] - Bump github.com/hashicorp/go-retryablehttp v0.7.5 -> v0.7.7 [[woodpecker-ci#3834](woodpecker-ci#3834)] ### ✨ Features - Gracefully shutdown server [[woodpecker-ci#3896](woodpecker-ci#3896)] - Gracefully shutdown agent [[woodpecker-ci#3895](woodpecker-ci#3895)] - Convert urls in logs to links [[woodpecker-ci#3904](woodpecker-ci#3904)] - Allow login using multiple forges [[woodpecker-ci#3822](woodpecker-ci#3822)] - Global and organization registries [[woodpecker-ci#1672](woodpecker-ci#1672)] - Cli get repo from git remote [[woodpecker-ci#3830](woodpecker-ci#3830)] - Add api for forges [[woodpecker-ci#3733](woodpecker-ci#3733)] ### 📈 Enhancement - Cli fix pipeline logs [[woodpecker-ci#3913](woodpecker-ci#3913)] - Migrate to github.com/urfave/cli/v3 [[woodpecker-ci#2951](woodpecker-ci#2951)] - Allow to change the working directory also for plugins and services [[woodpecker-ci#3914](woodpecker-ci#3914)] - Remove `unplugin-icons` [[woodpecker-ci#3809](woodpecker-ci#3809)] - Release windows binaries as zip file [[woodpecker-ci#3906](woodpecker-ci#3906)] - Convert to openapi 3.0 [[woodpecker-ci#3897](woodpecker-ci#3897)] - Enhance pipeline list [[woodpecker-ci#3898](woodpecker-ci#3898)] - Add user registries UI [[woodpecker-ci#3888](woodpecker-ci#3888)] - Sort users by login [[woodpecker-ci#3891](woodpecker-ci#3891)] - Exclude dummy backend in production [[woodpecker-ci#3877](woodpecker-ci#3877)] - Fix deploy task env [[woodpecker-ci#3878](woodpecker-ci#3878)] - Get default branch and show message in pipeline list [[woodpecker-ci#3867](woodpecker-ci#3867)] - Add timestamp for last work done by agent [[woodpecker-ci#3844](woodpecker-ci#3844)] - Adjust logger types [[woodpecker-ci#3859](woodpecker-ci#3859)] - Cleanup state reporting [[woodpecker-ci#3850](woodpecker-ci#3850)] - Unify DB tables/columns [[woodpecker-ci#3806](woodpecker-ci#3806)] - Let webhook pass on pipeline parsing error [[woodpecker-ci#3829](woodpecker-ci#3829)] - Exclude mocks from release build [[woodpecker-ci#3831](woodpecker-ci#3831)] - K8s secrets reference from step [[woodpecker-ci#3655](woodpecker-ci#3655)] ### 🐛 Bug Fixes - Handle empty repositories in gitea when listing PRs [[woodpecker-ci#3925](woodpecker-ci#3925)] - Update alpine package dep for docker images [[woodpecker-ci#3917](woodpecker-ci#3917)] - Don't report error if agent was terminated gracefully [[woodpecker-ci#3894](woodpecker-ci#3894)] - Let agents continuously report their health [[woodpecker-ci#3893](woodpecker-ci#3893)] - Ignore warnings for cli exec [[woodpecker-ci#3868](woodpecker-ci#3868)] - Correct favicon states [[woodpecker-ci#3832](woodpecker-ci#3832)] - Cleanup of the login flow and tests [[woodpecker-ci#3810](woodpecker-ci#3810)] - Fix newlines in logs [[woodpecker-ci#3808](woodpecker-ci#3808)] - Fix authentication error handling [[woodpecker-ci#3807](woodpecker-ci#3807)] ### 📚 Documentation - Streamline docs for new users [[woodpecker-ci#3803](woodpecker-ci#3803)] - Add mastodon verification [[woodpecker-ci#3843](woodpecker-ci#3843)] - chore(deps): update docs npm deps non-major [[woodpecker-ci#3837](woodpecker-ci#3837)] - fix(deps): update docs npm deps non-major [[woodpecker-ci#3824](woodpecker-ci#3824)] - Add openSUSE package [[woodpecker-ci#3800](woodpecker-ci#3800)] - chore(deps): update docs npm deps non-major [[woodpecker-ci#3798](woodpecker-ci#3798)] - Add "Docker Tags" Plugin [[woodpecker-ci#3796](woodpecker-ci#3796)] - chore(deps): update dependency marked to v13 [[woodpecker-ci#3792](woodpecker-ci#3792)] - chore: fix some comments [[woodpecker-ci#3788](woodpecker-ci#3788)] ### Misc - chore(deps): update web npm deps non-major [[woodpecker-ci#3930](woodpecker-ci#3930)] - chore(deps): update dependency vitest to v2 [[woodpecker-ci#3905](woodpecker-ci#3905)] - fix(deps): update module github.com/google/go-github/v62 to v63 [[woodpecker-ci#3910](woodpecker-ci#3910)] - chore(deps): update docker.io/woodpeckerci/plugin-docker-buildx docker tag to v4.1.0 [[woodpecker-ci#3908](woodpecker-ci#3908)] - Update plugin-git and add renovate trigger [[woodpecker-ci#3901](woodpecker-ci#3901)] - chore(deps): update docker.io/mstruebing/editorconfig-checker docker tag to v3.0.3 [[woodpecker-ci#3903](woodpecker-ci#3903)] - fix(deps): update golang-packages [[woodpecker-ci#3875](woodpecker-ci#3875)] - chore(deps): lock file maintenance [[woodpecker-ci#3876](woodpecker-ci#3876)] - [pre-commit.ci] pre-commit autoupdate [[woodpecker-ci#3862](woodpecker-ci#3862)] - Add dummy backend [[woodpecker-ci#3820](woodpecker-ci#3820)] - chore(deps): update dependency replace-in-file to v8 [[woodpecker-ci#3852](woodpecker-ci#3852)] - Update forgejo sdk [[woodpecker-ci#3840](woodpecker-ci#3840)] - chore(deps): lock file maintenance [[woodpecker-ci#3838](woodpecker-ci#3838)] - Allow to set dist dir using env var [[woodpecker-ci#3814](woodpecker-ci#3814)] - chore(deps): lock file maintenance [[woodpecker-ci#3805](woodpecker-ci#3805)] - chore(deps): update docker.io/lycheeverse/lychee docker tag to v0.15.1 [[woodpecker-ci#3797](woodpecker-ci#3797)]

lafriks added the feature add new functionality label Mar 23, 2023

lafriks added this to the 1.0.0 milestone Mar 23, 2023

anbraten removed this from the 1.0.0 milestone May 30, 2023

qwerty287 mentioned this pull request Feb 11, 2024

Refactor internal services #915

Merged

4 tasks

anbraten mentioned this pull request May 23, 2024

Allow adding private registries on the organization level #1448

Closed

3 tasks

Implement service and model changes for global/organization registries

315a3c4

lafriks force-pushed the feat/global_registry branch from e8c1e61 to 315a3c4 Compare July 2, 2024 14:39

lafriks added 2 commits July 2, 2024 18:26

Add API methods for organization and global registries

01c0bd4

Add methods to Woodpecker Go SDK

fe2f370

lafriks added 9 commits July 2, 2024 18:59

Update CLI commands to support org and global registries

d293871

Fix typo

5041d26

Fix tests

f58180b

Generate client mock

b645056

Fix lint

82dd52b

Refactor registry list and edit form to components

7c01d27

Add organization registries settings UI

bdfe146

Add global registries UI and handle readonly system registry credentials

3fb167e

Merge branch 'main' into feat/global_registry

003975c

lafriks marked this pull request as ready for review July 3, 2024 00:28

Fix lint

5da174c

lafriks added this to the 2.7.0 milestone Jul 3, 2024

Fix prettier warnings

6dd997f

anbraten reviewed Jul 3, 2024

View reviewed changes

lafriks and others added 2 commits July 3, 2024 12:17

Fix typo in comments

fee0bf9

Co-authored-by: Anbraten <6918444+anbraten@users.noreply.github.com>

Add missing import

3923bc3

lafriks added 4 commits July 3, 2024 12:37

Rename endoints to plural

945b927

Make it backward compatible

a23005d

Update migration not to include new table structure sync

c3551b6

Refactor registry managment CLI to admin/org/repo subcommands

e0bf3e8

anbraten reviewed Jul 3, 2024

View reviewed changes

cli/repo/registry/registry.go Outdated Show resolved Hide resolved

anbraten approved these changes Jul 3, 2024

View reviewed changes

lafriks added 3 commits July 3, 2024 15:05

Fix invalid return value

3298d4d

Fix duplicate code

df69130

Ignore unparam for common function

50eb9a6

lafriks enabled auto-merge (squash) July 3, 2024 13:16

lafriks merged commit 28e982f into woodpecker-ci:main Jul 3, 2024
7 checks passed

woodpecker-bot mentioned this pull request Jul 2, 2024

🎉 Release 2.7.0 #3793

Merged

1 task

lafriks deleted the feat/global_registry branch July 3, 2024 13:39

lafriks mentioned this pull request Jul 12, 2024

User registries #3889

Closed

BrewTestBot mentioned this pull request Jul 18, 2024

woodpecker-cli 2.7.0 Homebrew/homebrew-core#177789

Merged

woodpecker-bot mentioned this pull request Jul 19, 2024

🎉 Release 3.0.0 #3938

Closed

1 task

6543 pushed a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024

Global and organization registries (woodpecker-ci#1672)

c7fef8e

Co-authored-by: Anbraten <6918444+anbraten@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Global and organization registries #1672

Global and organization registries #1672

lafriks commented Mar 23, 2023 •

edited

Loading

codecov-commenter commented Mar 23, 2023 •

edited by codecov bot

Loading

lonix1 commented Jul 30, 2023

woodpecker-bot commented Jul 2, 2024 •

edited

Loading

lafriks commented Jul 3, 2024

lafriks commented Jul 3, 2024

qwerty287 commented Jul 8, 2024

Global and organization registries #1672

Global and organization registries #1672

Conversation

lafriks commented Mar 23, 2023 • edited Loading

codecov-commenter commented Mar 23, 2023 • edited by codecov bot Loading

Codecov Report

lonix1 commented Jul 30, 2023

woodpecker-bot commented Jul 2, 2024 • edited Loading

lafriks commented Jul 3, 2024

lafriks commented Jul 3, 2024

qwerty287 commented Jul 8, 2024

lafriks commented Mar 23, 2023 •

edited

Loading

codecov-commenter commented Mar 23, 2023 •

edited by codecov bot

Loading

woodpecker-bot commented Jul 2, 2024 •

edited

Loading