Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add own workflow model #1784

Merged
merged 43 commits into from
Jun 27, 2023
Merged

Add own workflow model #1784

merged 43 commits into from
Jun 27, 2023

Conversation

qwerty287
Copy link
Contributor

Closes #1287

@qwerty287 qwerty287 added this to the 1.0.0 milestone May 29, 2023
@qwerty287 qwerty287 marked this pull request as draft May 29, 2023 15:14
@woodpecker-bot

This comment was marked as outdated.

Sign in to view
@qwerty287

This comment was marked as outdated.

Sign in to view
@qwerty287 qwerty287 added the refactor delete or replace old code label May 29, 2023
@anbraten

This comment was marked as outdated.

Sign in to view
@qwerty287

This comment was marked as outdated.

Sign in to view
@qwerty287

This comment was marked as outdated.

Sign in to view
@qwerty287

This comment was marked as outdated.

Sign in to view
@codecov-commenter

This comment was marked as outdated.

Sign in to view
@6543 6543 added this to the 1.0.0 milestone Jun 16, 2023
@qwerty287
Copy link
Contributor Author

@6543
Logs are working totally fine for me.
What do you mean by "cancelling crons"?

@6543
Copy link
Member

6543 commented Jun 19, 2023

well in master there did land some bugfixes that could address that ...

I'm just waiting for #1784 (comment) to be addressed @qwerty287

after that I'll retest :)

@qwerty287
Copy link
Contributor Author

Ah yeah, missed that

@6543
Copy link
Member

6543 commented Jun 19, 2023

@qwerty287 updated to latest maister

@qwerty287
Copy link
Contributor Author

@6543 added tests

@6543 6543 self-requested a review June 20, 2023 05:22
@pat-s
Copy link
Contributor

pat-s commented Jun 27, 2023

Does this need more testing or is it ready to merge? Can't quite infer it from the last comments.

@qwerty287 I guess you've tested this already on your instance?

@6543 6543 merged commit 3033abc into woodpecker-ci:master Jun 27, 2023
@qwerty287
Copy link
Contributor Author

@pat-s Yes, it's tested from my side (and @6543 did too)

@6543
Copy link
Member

6543 commented Jun 27, 2023 •
edited
Loading

af20d2b and 3e0bb3d fixed my issues ... just did not had time to test it again - till today

@qwerty287 qwerty287 deleted the workflow-model branch June 27, 2023 17:30
@qwerty287 qwerty287 mentioned this pull request Jun 29, 2023
Merged
6543 pushed a commit that referenced this pull request Jun 29, 2023
@qwerty287
Fix pipeline status calculation/reporting (#1898)
cd982fc 
Closes #1895 
Regression of #1784
@qwerty287 qwerty287 mentioned this pull request Jul 2, 2023
Merged
anbraten pushed a commit that referenced this pull request Jul 2, 2023
@qwerty287
Fix default value (#1916)
9dc839b 
From #1784 and #1898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbraten anbraten anbraten left review comments

@lafriks lafriks lafriks left review comments

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
refactor delete or replace old code server
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Create own model workflow for (parent) procs
7 participants
@qwerty287 @woodpecker-bot @anbraten @codecov-commenter @6543 @pat-s @lafriks