Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve built-in variables for global when filtered too #1790

Merged
merged 26 commits into from
Jun 4, 2023
Merged

Resolve built-in variables for global when filtered too #1790

merged 26 commits into from
Jun 4, 2023

Conversation

6543
Copy link
Member

@6543 6543 commented May 31, 2023 •
edited
Loading

@6543 6543 added bug Something isn't working server labels May 31, 2023
@6543 6543 added the breaking will break existing installations if no manual action happens label Jun 2, 2023
@6543 6543 marked this pull request as ready for review June 2, 2023 01:34
@6543 6543 changed the title WIP: fix env var resolve on global when filter Resolve built-in variables for global when filtered too Jun 2, 2023
@6543 6543 added the refactor delete or replace old code label Jun 2, 2023
@6543 6543 added this to the 1.0.0 milestone Jun 2, 2023
@6543
Copy link
Member Author

6543 commented Jun 2, 2023 •
edited
Loading

one more preparation to make pipeline/* code independent from server/* ...

@woodpecker-bot
Copy link
Contributor

woodpecker-bot commented Jun 2, 2023 •
edited
Loading

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-1790.surge.sh

@codecov-commenter

This comment was marked as off-topic.

Sign in to view
@6543 6543 requested a review from a team June 3, 2023 01:18
@6543 6543 mentioned this pull request Jun 3, 2023
Closed
@6543 6543 requested a review from anbraten June 3, 2023 21:40
@6543 6543 mentioned this pull request Jun 3, 2023
Closed
anbraten
anbraten reviewed Jun 4, 2023
View reviewed changes
pipeline/frontend/metadata/environment.go Outdated Show resolved Hide resolved
pipeline/frontend/metadata/environment.go Outdated Show resolved Hide resolved
server/pipeline/filter.go Outdated Show resolved Hide resolved
server/pipeline/filter.go Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Jun 4, 2023

@anbraten added prepair metadata to support nested repos

6543
6543 commented Jun 4, 2023
View reviewed changes
cli/exec/flags.go Outdated Show resolved Hide resolved
@6543 6543 requested a review from anbraten June 4, 2023 11:52
@6543
Copy link
Member Author

6543 commented Jun 4, 2023

If there is more, we should move it into a new pull this here is already large ...

@anbraten anbraten merged commit ea895ba into woodpecker-ci:master Jun 4, 2023
@6543 6543 deleted the fix_expand_global_when_filter_vars branch June 4, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
breaking will break existing installations if no manual action happens bug Something isn't working refactor delete or replace old code server
Projects
None yet
Milestone
1.0.0
4 participants
@6543 @woodpecker-bot @codecov-commenter @anbraten