Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also show WOODPECKER_HOST and WOODPECKER_SERVER_HOST environment variables in log messages #208

Merged
merged 1 commit into from
May 31, 2021

Conversation

marians
Copy link
Contributor

@marians marians commented May 29, 2021

If no server host is configured, messages like

DRONE_HOST/DRONE_SERVER_HOST is not properly configured

are printed. In fact, there are four different environment variables instead of two which can configure this value. If the user had used WOODPECKER_HOST or WOODPECKER_SERVER_HOST, they might not find the source of the error easily.

This PR changes the error message to include all four possible names.

@laszlocph laszlocph merged commit 8f76192 into woodpecker-ci:master May 31, 2021
@marians marians deleted the env-variables branch May 31, 2021 11:29
@6543 6543 added this to the v0.14.0 milestone Jun 18, 2021
@6543 6543 added the documentation docu & docs label Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation docu & docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants