Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use server-host as source for public links and warn if it is set to localhost #251

Merged
merged 4 commits into from
Aug 20, 2021

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Jul 20, 2021

closes #247

  • Currently the domain (hostname and schema) for public links (mainly webhooks) is gathered from the request url some client accessed the api from
    • It could be dangerous if the server is listening under some unintentional address
    • It could lead to problems where the ui is accessed by some private ip etc
    • It make the setup simpler if DRONE_SERVER is used for all public domains (has to be configured anyways)

resolves #143
resolves #142
resolves #177,

@anbraten anbraten changed the title Use server-host as source for public links Use server-host as source for public links and warn if it is set to localhost Jul 20, 2021
@6543 6543 added the enhancement improve existing features label Jul 20, 2021
@6543 6543 added this to the 0.15.0 milestone Jul 20, 2021
@anbraten anbraten mentioned this pull request Jul 31, 2021
58 tasks
@6543
Copy link
Member

6543 commented Aug 17, 2021

followup of #175

@6543 6543 force-pushed the use-server-host branch from 893e650 to b624436 Compare August 20, 2021 14:32
@6543 6543 merged commit 1a67fc6 into woodpecker-ci:master Aug 20, 2021
@anbraten anbraten deleted the use-server-host branch August 20, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features
Projects
None yet
2 participants