-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix listing Gitea repos #2768
Fix listing Gitea repos #2768
Conversation
@qwerty287 (or @mzampetakis) Feel free to re-use this PR for a proper fix, I am happy to use the PR images in the meantime. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2768 +/- ##
=======================================
Coverage 34.06% 34.07%
=======================================
Files 214 214
Lines 13777 13779 +2
=======================================
+ Hits 4693 4695 +2
Misses 8712 8712
Partials 372 372
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to block this for now - I think I'll be able to fix it tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a proper fix now. @pat-s Can you verify it's working?
This only affects gitea but no other forge.
Also, somebody else might review as I wrote this PR.
Tested. Works! Thanks a lot! Feel free to modify the title before merging. |
The code in question will prevent the return of all Gitea repos from the API. See #2491 (reply in thread) for a more detailed explanation.
Partially reverts #2374
Side ref: #2613
Not sure about the GH and GL parts, but the Gitea part needs fixing. This is just a quick fix to revert it.
cc @mzampetakis