Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix listing Gitea repos #2768

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Fix listing Gitea repos #2768

merged 4 commits into from
Nov 7, 2023

Conversation

pat-s
Copy link
Contributor

@pat-s pat-s commented Nov 6, 2023

The code in question will prevent the return of all Gitea repos from the API. See #2491 (reply in thread) for a more detailed explanation.

Partially reverts #2374

Side ref: #2613

Not sure about the GH and GL parts, but the Gitea part needs fixing. This is just a quick fix to revert it.

cc @mzampetakis

@pat-s pat-s added server forge/gitea gitea forge related regression fix a bug that was not released yet build_pr_images If set, the CI will build images for this PR and push to Dockerhub labels Nov 6, 2023
@pat-s pat-s requested a review from qwerty287 November 6, 2023 19:09
@pat-s
Copy link
Contributor Author

pat-s commented Nov 6, 2023

@qwerty287 (or @mzampetakis) Feel free to re-use this PR for a proper fix, I am happy to use the PR images in the meantime.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (731d471) 34.06% compared to head (e8f1b6f) 34.07%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2768   +/-   ##
=======================================
  Coverage   34.06%   34.07%           
=======================================
  Files         214      214           
  Lines       13777    13779    +2     
=======================================
+ Hits         4693     4695    +2     
  Misses       8712     8712           
  Partials      372      372           
Files Coverage Δ
cli/internal/util.go 11.42% <ø> (ø)
cmd/agent/agent.go 4.59% <ø> (ø)
cmd/agent/health.go 9.52% <ø> (ø)
cmd/agent/main.go 0.00% <ø> (ø)
pipeline/backend/docker/convert.go 8.66% <ø> (ø)
pipeline/backend/docker/docker.go 0.00% <ø> (ø)
pipeline/backend/kubernetes/kubernetes.go 0.00% <ø> (ø)
pipeline/backend/kubernetes/pod.go 0.00% <ø> (ø)
pipeline/backend/local/clone.go 0.00% <ø> (ø)
pipeline/backend/local/local.go 0.00% <ø> (ø)
... and 118 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to block this for now - I think I'll be able to fix it tomorrow.

Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a proper fix now. @pat-s Can you verify it's working?

This only affects gitea but no other forge.

Also, somebody else might review as I wrote this PR.

@qwerty287 qwerty287 added this to the 2.0.0 milestone Nov 7, 2023
@pat-s
Copy link
Contributor Author

pat-s commented Nov 7, 2023

Tested. Works! Thanks a lot! Feel free to modify the title before merging.

@qwerty287 qwerty287 changed the title Partially revert hiding archived (Gitea) repos Fix listing Gitea repos Nov 7, 2023
@qwerty287 qwerty287 merged commit 9d5ef11 into main Nov 7, 2023
2 checks passed
@qwerty287 qwerty287 deleted the revert-2374 branch November 7, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build_pr_images If set, the CI will build images for this PR and push to Dockerhub forge/gitea gitea forge related regression fix a bug that was not released yet server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants