Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go's vendoring #284

Merged
merged 6 commits into from
Aug 30, 2021
Merged

Use go's vendoring #284

merged 6 commits into from
Aug 30, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Aug 29, 2021

  • exec go mod tidy && go mod vendor update vendor folder after changes to go.mod

this way we can delete some go get steps on our CI and make it more resistant against external changes made by 3rd-party's ...

  • change .gitignore
  • add vendor folder
  • rm go get statements

@6543 6543 added wip build CI pipeline related labels Aug 29, 2021
@6543 6543 added this to the 0.15.0 milestone Aug 29, 2021
Copy link
Member

@anbraten anbraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to download and cache the vendor folder in CI instead of having it inside the repo to keep the repo size smaller?

Makefile Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Aug 30, 2021

Would it be possible to download and cache the vendor folder in CI instead of having it inside the repo to keep the repo size smaller?

that's how it's done now - and that's why it sometimes fail unrelated & storing it on an external storage miss the point either ...

@anbraten
Copy link
Member

anbraten commented Aug 30, 2021

that's how it's done now - and that's why it sometimes fail unrelated & storing it on an external storage miss the point either ...

Ahh okay. Sorry, now I get the whole point of this PR. 🤦🏾

@6543 6543 removed the wip label Aug 30, 2021
@6543 6543 merged commit 7551357 into woodpecker-ci:master Aug 30, 2021
@6543 6543 deleted the use-vendoring branch August 30, 2021 17:14
mscherer added a commit to mscherer/woodpecker that referenced this pull request Aug 31, 2021
6543 pushed a commit that referenced this pull request Sep 9, 2021
@6543 6543 mentioned this pull request Oct 8, 2021
6543 added a commit that referenced this pull request Oct 8, 2021
* use vendoring

* add tools.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CI pipeline related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants