Added protocol in port configuration

[zc-devs]

Closes #2727

[zc-devs]

Test

Pipeline

services:
  database:
    image: mysql
    environment:
      - MYSQL_DATABASE=test
      - MYSQL_ROOT_PASSWORD=example
    ports:
      - 3306/tcp
steps:
  get-version:
    image: ubuntu
    commands:
      - ( apt update && apt dist-upgrade -y && apt install -y mysql-client 2>&1 )> /dev/null
      - sleep 60s # need to wait for mysql-server init
      - echo 'SHOW VARIABLES LIKE "version"' | mysql -uroot -hdatabase test -pexample

Result

Service

apiVersion: v1
kind: Service
spec:
  ports:
    - name: port-3306
      protocol: TCP
      port: 3306
      targetPort: 3306
  selector:
    step: wp-01hj9gsstcw0nyjchk262fwfh2-0-services-0
  clusterIP: 2001:cafe:43::f429
  clusterIPs:
    - 2001:cafe:43::f429
  type: ClusterIP
  sessionAffinity: None
  ipFamilies:
    - IPv6
  ipFamilyPolicy: SingleStack
  internalTrafficPolicy: Cluster

Step Pod:

apiVersion: v1
kind: Pod
spec:
  containers:
    - name: wp-01hj9gsstcw0nyjchk262fwfh2-0-step-0
  hostAliases:
    - ip: 2001:cafe:43::f429
      hostnames:
        - database

Step's /etc/hosts

# Entries added by HostAliases.
2001:cafe:43::f429      database

[woodpecker-bot]

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-2993.surge.sh

[codecov]

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (9bbc446) 35.08% compared to head (c61c47d) 35.22%.

Files	Patch %	Lines
pipeline/frontend/yaml/compiler/convert.go	71.42%	5 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2993      +/-   ##
==========================================
+ Coverage   35.08%   35.22%   +0.13%     
==========================================
  Files         228      228              
  Lines       14852    14887      +35     
==========================================
+ Hits         5211     5244      +33     
- Misses       9257     9259       +2     
  Partials      384      384              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[qwerty287]

And is it possible to support this for docker as well? Only if it's supported at docker's side of course

[zc-devs]

If I understand correctly, in Docker it works in different way. There is Network shared between containers. There is no isolation between containers in a network, the ports are defined in Dockerfile. What port application in container listens to, that port will be available in shared network.

So, there is nothing to do for Docker, I think. If I'm wrong, correct me.

[6543]

docker images can specify ports but you can always tell the runtime to do otherwhise or add some

and udp is done similar: https://docs.docker.com/network/#published-ports

[zc-devs]

"This creates a firewall rule in the host, mapping a container port to a port on the Docker host to the outside world"

I'm not convinced.

---

nicolaka/netshoot has no exposed ports. I'm not exposing ports.

Server

> docker run -it --name server nicolaka/netshoot

# ip addr
ip addr
19: eth0@if20
    inet 172.17.0.2/16

# echo 'This is test UDP server' | nc -l -u 1234

Client

> docker run -it --name client nicolaka/netshoot

# ip addr
21: eth0@if22
    inet 172.17.0.3/16

# nc -v 172.17.0.2 1234
nc: connect to 172.17.0.2 port 1234 (tcp) failed: Connection refused

# nc -v -u 172.17.0.2 1234
Connection to 172.17.0.2 1234 port [udp/*] succeeded!
This is test UDP server

---

What port application in container listens to, that port will be available in shared network.

[6543]

@zc-devs yes the default network you use do prohibit this.

but asap you work within a dedicated create network you are able to do so:

docker-compose.yml

version: '3'

services:
  server:
    build: .
    networks:
      - docker-network

  client:
    build: .
    networks:
      - docker-network

networks:
  docker-network:

Dockerfile

FROM nicolaka/netshoot
CMD sleep 10m

this simulate woodpecker env better.

get the ips:

docker compose build
docker compose up -d
docker compose exec -it server /bin/bash -c "ip add | grep inet | grep -v '127.0.0.1'"

and make your experiment again:

docker compose exec -it server /bin/bash -c "echo 'This is test UDP server' | nc -l -u 1234"
docker compose exec -it server /bin/bash -c "nc -u -v <Server IP> 1234"

[6543]

☝️ in this regards they are not as isolated ... I have to look how docker backend do setup things :)

[zc-devs]

grep -v '127.0.0.1'

Why are you grepping localhost? It won't work, of course.

---

docker compose build
docker compose up -d

Server

# ip addr
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
       valid_lft forever preferred_lft forever
11: eth0@if12: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default 
    link/ether 02:42:ac:13:00:03 brd ff:ff:ff:ff:ff:ff link-netnsid 0
    inet 172.19.0.3/16 brd 172.19.255.255 scope global eth0
       valid_lft forever preferred_lft forever

# echo 'This is test UDP server' | nc -l -u 1234

Client

# nc -u -v 172.19.0.3 1234
Connection to 172.19.0.3 1234 port [udp/*] succeeded!
This is test UDP server

All is the same.

servicenetwork_docker-network.json
servicenetwork-client-1.json
servicenetwork-server-1.json

the ports are defined in Dockerfile

I should have been more accurate here. Exposed ports make container available outside the network. In the rest I'm right.

---

And is it possible to support this for docker as well?

If we used port publishing (exposing) in the docker backend, then I could add this. But we do not.

And if we do, then github.com\docker\docker@v24.0.7+incompatible\api\types\container\hostconfig.go:HostConfig:PortBindings will serve that case, I suppose.

---

Thanks for comments, though. It made me think about it and I ended with...
\me went make a prototype

[zc-devs]

and I ended with

Forget, doesn't work well.

Instead, I found another flaw. Now ports are set in service's Pod/container too.

Test

Service's Pod:

spec:
  containers:
    - name: wp-01hjebs09gerq904fjnde4tyw3-0-services-0
      image: digitalocean/doks-debug
      ports:
        - containerPort: 1234
          protocol: UDP