-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move docker resource limit settings from server to agent #3174
Move docker resource limit settings from server to agent #3174
Conversation
so you can set it per agent and not per server
Maybe server can still provide defaults? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3174 +/- ##
==========================================
- Coverage 26.60% 26.54% -0.07%
==========================================
Files 373 374 +1
Lines 27081 27045 -36
==========================================
- Hits 7205 7178 -27
+ Misses 19213 19210 -3
+ Partials 663 657 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
no I'm against this ... we for example also do not set the tmp path for the local backend on the server side |
I have no strong opinion about this but that would avoid it being breaking change |
well so it looks like v3.0.0 is right around the corner |
I think it the default fits well into the agent settings, specific settings however should probably be still settable via the pipeline config. We just need to move it into the backend config section. |
well make it non breaking for now then ... but add a TODO comment so we can do so on next majour bump also I add a docker specific config like with kubernetis for limiting per step |
Tearing down https://woodpecker-ci-woodpecker-pr-3174.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fits better into the agent than server but I agree, it should be settable in the step config like for k8s, as every container usually has a different requirement.
Given it's breaking due to the move, it fits well into 3.0.
yes have it alser per stes should be an backend option like done for kubes settings. this will be a new issue to address ... |
so you can set it per agent and not per server
related to #3156 to cleanup the step definition