Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate HTTP config service #3179

Closed
wants to merge 2 commits into from

Conversation

qwerty287
Copy link
Contributor

As we have an addon system now, we can migrate http config services to them and remove support for http config services in the next major (so deprecate for now).

If you're currently using the http config service, you need to write the server yourself, there's only an example provided by us.
Then you can also write the addon I think. This is much faster than a HTTP request, simplifies typings and thus reduces errors etc. and does not require you to run an additional server.

Of course, we would need to update https://github.com/woodpecker-ci/example-config-service repository for this, I'm happy to open a PR for this.

@qwerty287 qwerty287 added the refactor delete or replace old code label Jan 12, 2024
@qwerty287 qwerty287 added this to the 2.3.0 milestone Jan 12, 2024
@qwerty287 qwerty287 requested a review from a team January 12, 2024 16:06
@xoxys
Copy link
Member

xoxys commented Jan 12, 2024

I tend to disagree and Im not sure yet if the addon system is really the way to go. The approach chosen by drone to extend parts by an external http service (https://docs.drone.io/extensions/overview/) is IMO way more flexible and easier do adopt by end users:

  • extensions can be written in any language
  • extensions are unrelated to the server version
  • ...

@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Jan 12, 2024

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-3179.surge.sh

@qwerty287
Copy link
Contributor Author

I get your point, however, there's also #915 in progress which will allow to use http extension per repo. I still think this should be supported, but on a global level, I'd replace it with addons.

@xoxys
Copy link
Member

xoxys commented Jan 12, 2024

Per repo doesnt really scale in my opinion. Just wanted to add my experience with drone in the last year and the http extension system was quiet handy.

@6543
Copy link
Member

6543 commented Jan 12, 2024

I would also like to have it as core component.

@6543
Copy link
Member

6543 commented Jan 12, 2024

As long as we dont have a good way for plugins to:

  1. Have core components work on windows too
  2. Deliver them in a "cloud native way"

I'm strictly against relaying on them

@6543
Copy link
Member

6543 commented Jan 12, 2024

Plugins currently overload stuff instead of extending things. It"s great for thirdparty but not for our own components.

@6543 6543 closed this Jan 12, 2024
@qwerty287 qwerty287 deleted the dep-http-conf branch January 13, 2024 06:19
@qwerty287 qwerty287 removed this from the 2.3.0 milestone Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor delete or replace old code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants