Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update theme on system color mode change #3296

Merged
merged 8 commits into from
Jan 30, 2024
Merged

Update theme on system color mode change #3296

merged 8 commits into from
Jan 30, 2024

Conversation

pat-s
Copy link
Contributor

@pat-s pat-s commented Jan 30, 2024

Currently, when theme auto is set and the system theme changes, users need to reload the site themselves.

This PR adds an even listener which listens for such changes and reloads the theme automatically in the background.

@pat-s pat-s added ui frontend related enhancement improve existing features build_pr_images If set, the CI will build images for this PR and push to Dockerhub labels Jan 30, 2024
@pat-s pat-s force-pushed the auto-theme-reload branch from bcb2e08 to 1686b85 Compare January 30, 2024 08:53
anbraten
anbraten reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@anbraten anbraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. I think you can also watch on the system-theme from the useColorMode composition.

web/src/compositions/useTheme.ts Outdated Show resolved Hide resolved
web/src/compositions/useTheme.ts Outdated Show resolved Hide resolved
pat-s and others added 2 commits January 30, 2024 10:14
@pat-s @anbraten
Update web/src/compositions/useTheme.ts
d6e0df0 
Co-authored-by: Anbraten <anton@ju60.de>
@pat-s @anbraten
Update web/src/compositions/useTheme.ts
e1810e1 
Co-authored-by: Anbraten <anton@ju60.de>
anbraten
anbraten reviewed Jan 30, 2024
View reviewed changes
web/src/compositions/useTheme.ts Outdated Show resolved Hide resolved
web/src/compositions/useTheme.ts Outdated Show resolved Hide resolved
web/src/compositions/useTheme.ts Outdated Show resolved Hide resolved
pat-s and others added 4 commits January 30, 2024 10:26
@pat-s @anbraten
Update web/src/compositions/useTheme.ts
15f08c4 
Co-authored-by: Anbraten <anton@ju60.de>
@pat-s @anbraten
Update web/src/compositions/useTheme.ts
31321a9 
Co-authored-by: Anbraten <anton@ju60.de>
@pat-s @anbraten
Update web/src/compositions/useTheme.ts
79133f7 
Co-authored-by: Anbraten <anton@ju60.de>
@pat-s
lint
9709d40
@pat-s
Copy link
Contributor Author

pat-s commented Jan 30, 2024

Tested locally again. Seems to work.

@anbraten anbraten merged commit da4bd8b into main Jan 30, 2024
6 checks passed
@anbraten anbraten deleted the auto-theme-reload branch January 30, 2024 10:00
@anbraten anbraten changed the title Reload site on theme change Update theme on system color mode change Jan 30, 2024
@woodpecker-bot woodpecker-bot mentioned this pull request Jan 27, 2024
Merged
1 task
pat-s pushed a commit that referenced this pull request Jan 31, 2024
@woodpecker-bot
🎉 Release 2.3.0 (#3249)
ee56a6a 
This PR was opened by the
[ready-release-go](https://github.com/woodpecker-ci/plugin-ready-release-go)
plugin. When you're ready to do a release, you can merge this
pull-request and a new release with version `2.3.0` will be created
automatically. If you're not ready to do a release yet, that's fine,
whenever you add more changes to `main` this pull-request will be
updated.

## Options

- [ ] Mark this version as a release candidate

##
[2.3.0](https://github.com/woodpecker-ci/woodpecker/releases/tag/2.3.0)
- 2024-01-31

### ✨ Features

- Add release event
[[#3226](#3226)]

### 📚 Documentation

- Add release types
[[#3303](#3303)]
- Add opencollective footer
[[#3281](#3281)]
- Use array syntax in docs
[[#3242](#3242)]

### 🐛 Bug Fixes

- Fix Gitpod: Gitea auth token creation
[[#3299](#3299)]
- Fix agent updating
[[#3287](#3287)]
- Sanitize pod's step label
[[#3275](#3275)]
- Pipeline errors must be an array
[[#3276](#3276)]
- fix bitbucket SSO using UUID from bitbucket api response as
ForgeRemoteID
[[#3265](#3265)]
- fix: bug pod service without label service
[[#3256](#3256)]
- Fix disabling PRs
[[#3258](#3258)]
- fix: bug annotations
[[#3255](#3255)]

### 📈 Enhancement

- Update theme on system color mode change
[[#3296](#3296)]
- Improve secrets availability checks
[[#3271](#3271)]
- Load more pipeline log lines (500 => 5000)
[[#3212](#3212)]
- Clean up models
[[#3228](#3228)]

### Misc

- chore(deps): update docker.io/techknowlogick/xgo docker tag to
go-1.21.6
[[#3294](#3294)]
- fix(deps): update docs npm deps non-major
[[#3295](#3295)]
- Remove deprecated `group` from config
[[#3289](#3289)]
- Add spellcheck config
[[#3018](#3018)]
- fix(deps): update golang (packages)
[[#3284](#3284)]
- chore(deps): lock file maintenance
[[#3274](#3274)]
- chore(deps): update web npm deps non-major
[[#3273](#3273)]
- Pin prettier version
[[#3260](#3260)]
- Fix prettier
[[#3259](#3259)]
- Update UI building in Makefile
[[#3250](#3250)]
@BrewTestBot BrewTestBot mentioned this pull request Jan 31, 2024
Merged
fernandrone pushed a commit to quintoandar/woodpecker that referenced this pull request Feb 1, 2024
@pat-s @anbraten @fernandrone
Update theme on system color mode change (woodpecker-ci#3296)
cfb6014 
Currently, when theme `auto` is set and the system theme changes, users
need to reload the site themselves.

This PR adds an even listener which listens for such changes and reloads
the theme automatically in the background.

---------

Co-authored-by: Anbraten <anton@ju60.de>
fernandrone pushed a commit to quintoandar/woodpecker that referenced this pull request Feb 1, 2024
@woodpecker-bot @fernandrone
🎉 Release 2.3.0 (woodpecker-ci#3249)
e1d4a16 
This PR was opened by the
[ready-release-go](https://github.com/woodpecker-ci/plugin-ready-release-go)
plugin. When you're ready to do a release, you can merge this
pull-request and a new release with version `2.3.0` will be created
automatically. If you're not ready to do a release yet, that's fine,
whenever you add more changes to `main` this pull-request will be
updated.

## Options

- [ ] Mark this version as a release candidate

##
[2.3.0](https://github.com/woodpecker-ci/woodpecker/releases/tag/2.3.0)
- 2024-01-31

### ✨ Features

- Add release event
[[woodpecker-ci#3226](woodpecker-ci#3226)]

### 📚 Documentation

- Add release types
[[woodpecker-ci#3303](woodpecker-ci#3303)]
- Add opencollective footer
[[woodpecker-ci#3281](woodpecker-ci#3281)]
- Use array syntax in docs
[[woodpecker-ci#3242](woodpecker-ci#3242)]

### 🐛 Bug Fixes

- Fix Gitpod: Gitea auth token creation
[[woodpecker-ci#3299](woodpecker-ci#3299)]
- Fix agent updating
[[woodpecker-ci#3287](woodpecker-ci#3287)]
- Sanitize pod's step label
[[woodpecker-ci#3275](woodpecker-ci#3275)]
- Pipeline errors must be an array
[[woodpecker-ci#3276](woodpecker-ci#3276)]
- fix bitbucket SSO using UUID from bitbucket api response as
ForgeRemoteID
[[woodpecker-ci#3265](woodpecker-ci#3265)]
- fix: bug pod service without label service
[[woodpecker-ci#3256](woodpecker-ci#3256)]
- Fix disabling PRs
[[woodpecker-ci#3258](woodpecker-ci#3258)]
- fix: bug annotations
[[woodpecker-ci#3255](woodpecker-ci#3255)]

### 📈 Enhancement

- Update theme on system color mode change
[[woodpecker-ci#3296](woodpecker-ci#3296)]
- Improve secrets availability checks
[[woodpecker-ci#3271](woodpecker-ci#3271)]
- Load more pipeline log lines (500 => 5000)
[[woodpecker-ci#3212](woodpecker-ci#3212)]
- Clean up models
[[woodpecker-ci#3228](woodpecker-ci#3228)]

### Misc

- chore(deps): update docker.io/techknowlogick/xgo docker tag to
go-1.21.6
[[woodpecker-ci#3294](woodpecker-ci#3294)]
- fix(deps): update docs npm deps non-major
[[woodpecker-ci#3295](woodpecker-ci#3295)]
- Remove deprecated `group` from config
[[woodpecker-ci#3289](woodpecker-ci#3289)]
- Add spellcheck config
[[woodpecker-ci#3018](woodpecker-ci#3018)]
- fix(deps): update golang (packages)
[[woodpecker-ci#3284](woodpecker-ci#3284)]
- chore(deps): lock file maintenance
[[woodpecker-ci#3274](woodpecker-ci#3274)]
- chore(deps): update web npm deps non-major
[[woodpecker-ci#3273](woodpecker-ci#3273)]
- Pin prettier version
[[woodpecker-ci#3260](woodpecker-ci#3260)]
- Fix prettier
[[woodpecker-ci#3259](woodpecker-ci#3259)]
- Update UI building in Makefile
[[woodpecker-ci#3250](woodpecker-ci#3250)]
quotengrote pushed a commit to quotengrote/ansible that referenced this pull request Feb 1, 2024
@quotengrote
chore(deps): update woodpeckerci/woodpecker-server docker tag to v2.3…
2c20b5c 
….0 (#707)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [woodpeckerci/woodpecker-server](https://github.com/woodpecker-ci/woodpecker) | minor | `v2.2.2` -> `v2.3.0` |

---

### Release Notes

<details>
<summary>woodpecker-ci/woodpecker (woodpeckerci/woodpecker-server)</summary>

### [`v2.3.0`](https://github.com/woodpecker-ci/woodpecker/releases/tag/v2.3.0): 2.3.0

[Compare Source](woodpecker-ci/woodpecker@v2.2.2...v2.3.0)

#### [2.3.0](https://github.com/woodpecker-ci/woodpecker/releases/tag/2.3.0) - 2024-01-31

##### ❤️ Thanks to all contributors! ❤️

[@&#8203;anbraten](https://github.com/anbraten), [@&#8203;HerHde](https://github.com/HerHde), [@&#8203;qwerty287](https://github.com/qwerty287), [@&#8203;pat-s](https://github.com/pat-s), [@&#8203;renovate](https://github.com/renovate)\[bot], [@&#8203;lukashass](https://github.com/lukashass), [@&#8203;zc-devs](https://github.com/zc-devs), [@&#8203;Alonsohhl](https://github.com/Alonsohhl), [@&#8203;healdropper](https://github.com/healdropper), [@&#8203;eliasscosta](https://github.com/eliasscosta), [@&#8203;runephilosof-karnovgroup](https://github.com/runephilosof-karnovgroup)

##### ✨ Features

-   Add release event \[[#&#8203;3226](woodpecker-ci/woodpecker#3226)]

##### 📚 Documentation

-   Add release types \[[#&#8203;3303](woodpecker-ci/woodpecker#3303)]
-   Add opencollective footer \[[#&#8203;3281](woodpecker-ci/woodpecker#3281)]
-   Use array syntax in docs \[[#&#8203;3242](woodpecker-ci/woodpecker#3242)]

##### 🐛 Bug Fixes

-   Fix Gitpod: Gitea auth token creation \[[#&#8203;3299](woodpecker-ci/woodpecker#3299)]
-   Fix agent updating \[[#&#8203;3287](woodpecker-ci/woodpecker#3287)]
-   Sanitize pod's step label \[[#&#8203;3275](woodpecker-ci/woodpecker#3275)]
-   Pipeline errors must be an array \[[#&#8203;3276](woodpecker-ci/woodpecker#3276)]
-   fix bitbucket SSO using UUID from bitbucket api response as ForgeRemoteID \[[#&#8203;3265](woodpecker-ci/woodpecker#3265)]
-   fix: bug pod service without label service \[[#&#8203;3256](woodpecker-ci/woodpecker#3256)]
-   Fix disabling PRs \[[#&#8203;3258](woodpecker-ci/woodpecker#3258)]
-   fix: bug annotations \[[#&#8203;3255](woodpecker-ci/woodpecker#3255)]

##### 📈 Enhancement

-   Update theme on system color mode change \[[#&#8203;3296](woodpecker-ci/woodpecker#3296)]
-   Improve secrets availability checks \[[#&#8203;3271](woodpecker-ci/woodpecker#3271)]
-   Load more pipeline log lines (500 => 5000) \[[#&#8203;3212](woodpecker-ci/woodpecker#3212)]
-   Clean up models \[[#&#8203;3228](woodpecker-ci/woodpecker#3228)]

##### Misc

-   chore(deps): update docker.io/techknowlogick/xgo docker tag to go-1.21.6 \[[#&#8203;3294](woodpecker-ci/woodpecker#3294)]
-   fix(deps): update docs npm deps non-major \[[#&#8203;3295](woodpecker-ci/woodpecker#3295)]
-   Remove deprecated `group` from config \[[#&#8203;3289](woodpecker-ci/woodpecker#3289)]
-   Add spellcheck config \[[#&#8203;3018](woodpecker-ci/woodpecker#3018)]
-   fix(deps): update golang (packages) \[[#&#8203;3284](woodpecker-ci/woodpecker#3284)]
-   chore(deps): lock file maintenance \[[#&#8203;3274](woodpecker-ci/woodpecker#3274)]
-   chore(deps): update web npm deps non-major \[[#&#8203;3273](woodpecker-ci/woodpecker#3273)]
-   Pin prettier version \[[#&#8203;3260](woodpecker-ci/woodpecker#3260)]
-   Fix prettier \[[#&#8203;3259](woodpecker-ci/woodpecker#3259)]
-   Update UI building in Makefile \[[#&#8203;3250](woodpecker-ci/woodpecker#3250)]

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNjUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE2NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->

Reviewed-on: https://git.mgrote.net/mg/homeserver/pulls/707
Co-authored-by: Renovate Bot <renovate@mgrote.net>
Co-committed-by: Renovate Bot <renovate@mgrote.net>
quotengrote pushed a commit to quotengrote/ansible that referenced this pull request Feb 1, 2024
@quotengrote
chore(deps): update woodpeckerci/woodpecker-agent docker tag to v2.3.…
6101a5b 
…0 (#706)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [woodpeckerci/woodpecker-agent](https://github.com/woodpecker-ci/woodpecker) | minor | `v2.2.2` -> `v2.3.0` |

---

### Release Notes

<details>
<summary>woodpecker-ci/woodpecker (woodpeckerci/woodpecker-agent)</summary>

### [`v2.3.0`](https://github.com/woodpecker-ci/woodpecker/releases/tag/v2.3.0): 2.3.0

[Compare Source](woodpecker-ci/woodpecker@v2.2.2...v2.3.0)

#### [2.3.0](https://github.com/woodpecker-ci/woodpecker/releases/tag/2.3.0) - 2024-01-31

##### ❤️ Thanks to all contributors! ❤️

[@&#8203;anbraten](https://github.com/anbraten), [@&#8203;HerHde](https://github.com/HerHde), [@&#8203;qwerty287](https://github.com/qwerty287), [@&#8203;pat-s](https://github.com/pat-s), [@&#8203;renovate](https://github.com/renovate)\[bot], [@&#8203;lukashass](https://github.com/lukashass), [@&#8203;zc-devs](https://github.com/zc-devs), [@&#8203;Alonsohhl](https://github.com/Alonsohhl), [@&#8203;healdropper](https://github.com/healdropper), [@&#8203;eliasscosta](https://github.com/eliasscosta), [@&#8203;runephilosof-karnovgroup](https://github.com/runephilosof-karnovgroup)

##### ✨ Features

-   Add release event \[[#&#8203;3226](woodpecker-ci/woodpecker#3226)]

##### 📚 Documentation

-   Add release types \[[#&#8203;3303](woodpecker-ci/woodpecker#3303)]
-   Add opencollective footer \[[#&#8203;3281](woodpecker-ci/woodpecker#3281)]
-   Use array syntax in docs \[[#&#8203;3242](woodpecker-ci/woodpecker#3242)]

##### 🐛 Bug Fixes

-   Fix Gitpod: Gitea auth token creation \[[#&#8203;3299](woodpecker-ci/woodpecker#3299)]
-   Fix agent updating \[[#&#8203;3287](woodpecker-ci/woodpecker#3287)]
-   Sanitize pod's step label \[[#&#8203;3275](woodpecker-ci/woodpecker#3275)]
-   Pipeline errors must be an array \[[#&#8203;3276](woodpecker-ci/woodpecker#3276)]
-   fix bitbucket SSO using UUID from bitbucket api response as ForgeRemoteID \[[#&#8203;3265](woodpecker-ci/woodpecker#3265)]
-   fix: bug pod service without label service \[[#&#8203;3256](woodpecker-ci/woodpecker#3256)]
-   Fix disabling PRs \[[#&#8203;3258](woodpecker-ci/woodpecker#3258)]
-   fix: bug annotations \[[#&#8203;3255](woodpecker-ci/woodpecker#3255)]

##### 📈 Enhancement

-   Update theme on system color mode change \[[#&#8203;3296](woodpecker-ci/woodpecker#3296)]
-   Improve secrets availability checks \[[#&#8203;3271](woodpecker-ci/woodpecker#3271)]
-   Load more pipeline log lines (500 => 5000) \[[#&#8203;3212](woodpecker-ci/woodpecker#3212)]
-   Clean up models \[[#&#8203;3228](woodpecker-ci/woodpecker#3228)]

##### Misc

-   chore(deps): update docker.io/techknowlogick/xgo docker tag to go-1.21.6 \[[#&#8203;3294](woodpecker-ci/woodpecker#3294)]
-   fix(deps): update docs npm deps non-major \[[#&#8203;3295](woodpecker-ci/woodpecker#3295)]
-   Remove deprecated `group` from config \[[#&#8203;3289](woodpecker-ci/woodpecker#3289)]
-   Add spellcheck config \[[#&#8203;3018](woodpecker-ci/woodpecker#3018)]
-   fix(deps): update golang (packages) \[[#&#8203;3284](woodpecker-ci/woodpecker#3284)]
-   chore(deps): lock file maintenance \[[#&#8203;3274](woodpecker-ci/woodpecker#3274)]
-   chore(deps): update web npm deps non-major \[[#&#8203;3273](woodpecker-ci/woodpecker#3273)]
-   Pin prettier version \[[#&#8203;3260](woodpecker-ci/woodpecker#3260)]
-   Fix prettier \[[#&#8203;3259](woodpecker-ci/woodpecker#3259)]
-   Update UI building in Makefile \[[#&#8203;3250](woodpecker-ci/woodpecker#3250)]

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNjUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE2NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->

Reviewed-on: https://git.mgrote.net/mg/homeserver/pulls/706
Co-authored-by: Renovate Bot <renovate@mgrote.net>
Co-committed-by: Renovate Bot <renovate@mgrote.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
build_pr_images If set, the CI will build images for this PR and push to Dockerhub enhancement improve existing features ui frontend related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pat-s @anbraten