Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve cron list #3947

Merged
merged 3 commits into from
Jul 20, 2024
Merged

Improve cron list #3947

merged 3 commits into from
Jul 20, 2024

Conversation

qwerty287
Copy link
Contributor

  • sort crons by name
  • use grid to have executions under each other (see screenshot)
  • hide next execution on mobile

old:
Screenshot 2024-07-20 at 14-17-10 Woodpecker

new:
Screenshot 2024-07-20 at 14-24-22 Woodpecker

fixes #2162 (comment)

@qwerty287 qwerty287 added ui frontend related enhancement improve existing features labels Jul 20, 2024
@qwerty287 qwerty287 requested a review from a team July 20, 2024 12:27
@codecov Codecov
Copy link

codecov bot commented Jul 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 26.84%. Comparing base (fed8093) to head (8d225fc).

Files Patch % Lines
server/store/datastore/cron.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3947      +/-   ##
==========================================
+ Coverage   26.83%   26.84%   +0.01%     
==========================================
  Files         394      394              
  Lines       27510    27510              
==========================================
+ Hits         7381     7386       +5     
+ Misses      19428    19423       -5     
  Partials      701      701

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qwerty287 qwerty287 merged commit 8a277e7 into woodpecker-ci:main Jul 20, 2024
8 of 9 checks passed
@qwerty287 qwerty287 deleted the cron-name branch July 20, 2024 16:15
This was referenced Jul 21, 2024
Closed
Closed
6543 pushed a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
@qwerty287 @6543
Improve cron list (woodpecker-ci#3947)
bb145fb
@woodpecker-bot woodpecker-bot mentioned this pull request Sep 8, 2024
Merged
1 task
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
Merged
1 task
@BrewTestBot BrewTestBot mentioned this pull request Jan 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lafriks lafriks lafriks approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
enhancement improve existing features ui frontend related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qwerty287 @lafriks @6543