Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cli plugin log purge recognize steps by name #3953

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

smainz
Copy link
Contributor

@smainz smainz commented Jul 21, 2024

Give a little love to woodpecker-cli pipeline log purge:

  • Make it recognize steps by name
  • Improve error messages in case of invalid/missing args
  • Add step name to message if only logs of a single stepare purged

closes #3922

@qwerty287 qwerty287 added enhancement improve existing features cli labels Jul 21, 2024
@qwerty287
Copy link
Contributor

This closes #3922 right?

@smainz
Copy link
Contributor Author

smainz commented Jul 21, 2024

yes, forgot to add this.

@woodpecker-bot
Copy link
Contributor

woodpecker-bot commented Jul 21, 2024

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-3953.surge.sh

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 26.87%. Comparing base (fed8093) to head (f167769).
Report is 2 commits behind head on main.

Files Patch % Lines
cli/log/log_purge.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3953      +/-   ##
==========================================
+ Coverage   26.83%   26.87%   +0.04%     
==========================================
  Files         394      394              
  Lines       27510    27517       +7     
==========================================
+ Hits         7381     7395      +14     
+ Misses      19428    19422       -6     
+ Partials      701      700       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qwerty287 qwerty287 merged commit c7b64e2 into woodpecker-ci:main Jul 21, 2024
8 of 9 checks passed
This was referenced Jul 21, 2024
@smainz smainz deleted the cli-pipeline-logs-purge branch July 23, 2024 18:57
6543 pushed a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
@woodpecker-bot woodpecker-bot mentioned this pull request Sep 8, 2024
1 task
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli enhancement improve existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

woodpecker-cli logs purge should uses step PID insted of step ID as argument
3 participants