-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify usage of secrets in docs #4099
Conversation
Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-4099.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the follow-up to my previous comment.
Besides the inline comments (which should be ported to the 2.7 docs if accepted), I am still missing a section which explains in detail:
- why
environment:
has been removed from all plugins (and starting with which version) - how using secrets via a plugin setting option is different/more secure
Co-authored-by: Patrick Schratz <patrick.schratz@gmail.com>
imho droping |
we depricated them and we could at least remove them from the docs ... |
@6543 Do you still plan to address the points in my last review comment? |
Well as they are blocking yes ... when i have time |
|
I'll take another look soon! |
docs/docs/20-usage/40-secrets.md
Outdated
- name: 'some commands using secrets' | ||
image: bash | ||
commands: | ||
- env | grep TOKEN | ||
+ environment: | ||
+ TOKEN_ENV: | ||
+ from_secret: secret_token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: 'some commands using secrets' | |
image: bash | |
commands: | |
- env | grep TOKEN | |
+ environment: | |
+ TOKEN_ENV: | |
+ from_secret: secret_token | |
- name: 'step name' | |
image: registry/repo/image:tag | |
commands: | |
- env | grep TOKEN | |
+ environment: | |
+ TOKEN: | |
+ from_secret: secret_token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can not apply :/
Co-authored-by: Patrick Schratz <patrick.schratz@gmail.com>
Co-authored-by: Patrick Schratz <patrick.schratz@gmail.com>
Co-authored-by: Patrick Schratz <patrick.schratz@gmail.com>
Co-authored-by: Patrick Schratz <patrick.schratz@gmail.com>
Co-authored-by: Patrick Schratz <patrick.schratz@gmail.com>
Co-authored-by: Patrick Schratz <patrick.schratz@gmail.com>
Co-authored-by: Patrick Schratz <patrick.schratz@gmail.com>
Superseeded by #4644. |
as per #4096 (comment)