Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print agent labels in debug mode (#4155) #4156

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 2, 2024

Backport #4155

because right now there is no way to figure this out in any way

@6543 6543 added agent enhancement improve existing features labels Oct 2, 2024
@6543 6543 changed the title Print angent labels in debug mode (#4155) Print agent labels in debug mode (#4155) Oct 3, 2024
Copy link
Contributor

@pat-s pat-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as #4155 ?

@@ -238,6 +238,8 @@ func run(ctx context.Context, c *cli.Command, backends []types.Backend) error {
return err
}

log.Debug().Any("labels", labels).Msgf("agent configured with labels")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better to make it info and merge with line 285

starting Woodpecker agent with version ... labels

Copy link
Member Author

@6543 6543 Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normaly you as admin have set it so you should know this. is for debugging porpuse

@6543
Copy link
Member Author

6543 commented Oct 3, 2024

This is the same as #4155 ?

Yes 1:1 backport

@6543 6543 requested a review from pat-s October 3, 2024 12:51
Copy link
Contributor

@pat-s pat-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, missed the target branch...

@pat-s pat-s merged commit 972e45d into woodpecker-ci:release/v2.7 Oct 3, 2024
6 of 7 checks passed
@6543 6543 deleted the debug-agent-labels branch October 3, 2024 13:54
@woodpecker-bot
Copy link
Contributor

@6543 6543 added skip-changelog and removed enhancement improve existing features labels Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants