-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete GitLab webhooks with partial URL match #4259
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pat-s
added
bug
Something isn't working
forge/gitlab
gitlab forge related
build_pr_images
If set, the CI will build images for this PR and push to Dockerhub
labels
Oct 26, 2024
pat-s
force-pushed
the
fix/gitlab-token-delete
branch
from
October 26, 2024 22:02
d400758
to
3326e6a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4259 +/- ##
==========================================
+ Coverage 26.47% 26.51% +0.04%
==========================================
Files 376 377 +1
Lines 27465 27447 -18
==========================================
+ Hits 7270 7278 +8
+ Misses 19530 19504 -26
Partials 665 665 ☔ View full report in Codecov by Sentry. |
anbraten
reviewed
Oct 27, 2024
anbraten
changed the title
fix: delete GitLab webhook on partial URL match
Delete GitLab webhooks with partial URL match
Oct 27, 2024
6543
approved these changes
Oct 27, 2024
|
Tearing down https://woodpecker-ci-woodpecker-pr-4259.surge.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
build_pr_images
If set, the CI will build images for this PR and push to Dockerhub
forge/gitlab
gitlab forge related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4248
webURL
!=hook.URL
(the latter always has theapi/token
suffix, the former doesn't)Tested on gitlab.com.