-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase WOODPECKER_FORGE_TIMEOUT
to fix config fetching for GitLab
#4262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pat-s
added
bug
Something isn't working
forge/gitlab
gitlab forge related
build_pr_images
If set, the CI will build images for this PR and push to Dockerhub
labels
Oct 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4262 +/- ##
==========================================
+ Coverage 26.47% 26.52% +0.05%
==========================================
Files 376 377 +1
Lines 27465 27451 -14
==========================================
+ Hits 7270 7282 +12
+ Misses 19530 19504 -26
Partials 665 665 ☔ View full report in Codecov by Sentry. |
pat-s
changed the title
GitLab: fix config fetching from forge
Increase Oct 27, 2024
WOODPECKER_FORGE_TIMEOUT
to fix config fetching for GitLab
6543
approved these changes
Oct 27, 2024
Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-4262.surge.sh |
still we can increase it a bit more ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
build_pr_images
If set, the CI will build images for this PR and push to Dockerhub
forge/gitlab
gitlab forge related
server
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4260
Config fetching on GL takes a bit longer due to the subgroup fetching and permissions checks.
In my case, I had 1/6 repos failing with the default of 3s. The repo only had two workflow files. Both were somewhat complex.
I assume that the workflow parsing combined with the subgroup checks exceeded the 3s here.
After bumping
WOODPECKER_FORGE_TIMEOUT
to 5s, it worked.Getting the initial config fetched seems to speed up future config pull as afterwards I was able to reduce
WOODPECKER_FORGE_TIMEOUT
again to 3s.However, to avoid such issues for users I think the default value should be bumped to (at least) 5s.
Additionally, I improved some of the log/trace outputs which helped me a bit along the way.